Azure blob adapter - #1366
Open
OisinHick wants to merge 5 commits into
Open
Conversation
- Added the base file to build on
- Added comment explaining adapter development status
amark
reviewed
Feb 27, 2024
amark
left a comment
amark
left a comment
Owner
There was a problem hiding this comment.
w000000000000 this is awesome, you're a hero!!! Quick couple anti-crash if-not-using-azure changes tho please.
| let containerClient; | ||
|
|
||
| const { Readable } = require('stream'); | ||
| const { BlobServiceClient, StorageSharedKeyCredential } = require("@azure/storage-blob"); |
| require('./rfs'); | ||
| require('./rs3'); | ||
| require('./wire'); | ||
| require('./azure') |
Owner
There was a problem hiding this comment.
correct! Tho, until you have it 100% working let's keep it commented out in PRs/prod. If a dev doesn't have Azure optionally NPM installed we want to make sure nothing crashes/breaks.
Owner
|
meow meow! |
Author
|
Seem to be encountering a problem with this in that gun seems to strobe for changes and its causing an error with azure. How does gun perform or how regularly does it strobe? Might be the last hurdle facing this |
Owner
|
@OisinHick what do you mean strobe? please DM / text me other platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP adapter for Azure. It is largely working in regards to booting etc however some fine-tuning is needed to fix how it strobes for the existence of a blob on boot, however, this shouldn't take too long to fix. This request is submitted per @amark advice in the Gun Gitter chat so the community can work further on this. Huge thanks to him for all his help and guidance.