fix: remove re2-wasm from node_moudle #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBose-amzn
previously approved these changes
Nov 24, 2025
Comment on lines
29
to
40
| // a WASM module, so it's excluded from the bundle and copied from local node_modules. | ||
| // Change this method once we figure out a better way to interact | ||
| // with the network-blocked builder system. | ||
| externalModules: ['re2-wasm'], | ||
| commandHooks: { | ||
| beforeBundling: (): string[] => [], | ||
| beforeInstall: (): string[] => [], | ||
| afterBundling: (inputDir: string, outputDir: string): string[] => [ | ||
| `mkdir -p ${outputDir}/node_modules`, | ||
| `cp -r ${inputDir}/node_modules/re2-wasm ${outputDir}/node_modules/`, | ||
| ], | ||
| }, |
Member
There was a problem hiding this comment.
It looks like we're copying the same thing to all of these. Can define this once in the lambdaDefaults module to avoid the risk of drift or copy errors?
Contributor
Author
There was a problem hiding this comment.
added re2-wasm in lambdaDefaults.
mattsb42-aws
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
According to the issue #87, moving
re2-wasmfromnode_moudlesoptions to support network-blocked internal build system.