Conversation
|
I forked 3 of @mosop repos for now. We will move back to his repo if/when he responds. |
elorest
left a comment
elorest
left a comment
There was a problem hiding this comment.
I'm fine with this. Do have a questions about each being added to filters though.
Thanks for doing this @drujensen @bcardiff
| filters[filter.precedence] << filter | ||
| end | ||
|
|
||
| def each(&block : {Symbol, Array(Filter)} -> _) |
There was a problem hiding this comment.
What was the point of adding this?
There was a problem hiding this comment.
it's now required to implement abstract methods in Crystal.
|
Looks like this is a breaking change because of ruby 0.30.0 and the new version of granite correct? |
|
@elorest yes, crystal 0.30.0 changes and the new DSL for Granite. thanks for approving. |
A bit late to reading over the changes. Did you mean ruby or crystal 0.30.0? Just making sure I don't need to read over something ruby specific :) |
|
@nsuchy that would be a really old version of ruby if it was. ;-) |
4 participants
From @bcardiff original PR:
A Crystal::VERSION check around
URI.decodeshould be added if you want amber to be warning free but also keep working in 0.29.0.You can double check in crystal-lang/crystal#7997 which encode/decode method apply better.
A couple of dependencies need to be updated also as stated in bcardiff@f28b442 after each of them are released. Do not use my forks as dependencies.