3) Modify ubuntu snp guest launch to generalize this across various linux distros#26
Open
LakshmiSaiHarika wants to merge 6 commits intoamd:mainfrom
Open
Conversation
LakshmiSaiHarika
force-pushed
the
standarize-ubuntu-snp-guest-launch
branch
from
e0d17d1 to
141245c
Compare
Collaborator
DGonzalezVillal
left a comment
DGonzalezVillal
left a comment
There was a problem hiding this comment.
lgtm, just consider the comments I made on the other PR.
This could have all been the same PR IMO.
Contributor
Author
|
Acutally, the other PR is for optimizing the guest creation process only, and I thought this could be helpful in case to to apply these commits in the coco branch without standardizing upstream ubuntu guest creation process |
LakshmiSaiHarika
force-pushed
the
standarize-ubuntu-snp-guest-launch
branch
from
141245c to
496b46a
Compare
Contributor
Author
|
LakshmiSaiHarika
force-pushed
the
standarize-ubuntu-snp-guest-launch
branch
from
496b46a to
e25758b
Compare
LakshmiSaiHarika
force-pushed
the
standarize-ubuntu-snp-guest-launch
branch
from
e25758b to
b4f8e3e
Compare
LakshmiSaiHarika
changed the title
Signed-off-by: Harika Nittala <lnittala@amd.com>
… a separate SNP guest This supports launch of various SNP Guests at the same time using unique guest name and guest qemu port. A separate SNP guest can be launched with the --guest-name and --guest-port command option as follows: ./snp.sh launch-guest --guest-name <user-guest-name> --guest-port <user-guest-port> Signed-off-by: Harika Nittala <lnittala@amd.com>
Updated to show the correct details for the guest SSH access. Signed-off-by: Harika Nittala <lnittala@amd.com>
…tion process Updated the ubuntu guest download process to download it once and re-use the same image to quickly create multiple guests with the improved performance. Update of the guest image download structure in ubuntu also helps to easily add support for the same in the other OS linux distros. Signed-off-by: Harika Nittala <lnittala@amd.com>
Modularized guest seed image creation in ubuntu to standardize this process across non-debian OS linux distros that has no support for cloud-localds utility supported in canonical distribution. Signed-off-by: Harika Nittala <lnittala@amd.com>
Generalize a way to get and install SNP guest kernel package(AMDSEV build), generalize initrd pattern to make it match across different OS linux distros(initrd/initramfs), and set the default ubuntu guest kernel append parameter. Signed-off-by: Harika Nittala <lnittala@amd.com>
LakshmiSaiHarika
force-pushed
the
standarize-ubuntu-snp-guest-launch
branch
from
b4f8e3e to
6b19318
Compare
DGonzalezVillal
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on branch pointing to PR #24
Updated to standardize the Ubuntu SNP setup and launch guest process to easily add support for the guest seed image creation, setup and launch SNP guest on on non-debian linux distros.