Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add phasTrak.AutoRegister #202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add phasTrak.AutoRegister #202

wants to merge 1 commit into from

Conversation

FXZFun
Copy link

@FXZFun FXZFun commented Oct 9, 2024

No description provided.

@FXZFun FXZFun requested a review from amis92 as a code owner October 9, 2024 21:18
viceroypenguin
viceroypenguin suggested changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@viceroypenguin viceroypenguin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package should be rejected, as it (illegally) removes the existing copyright claim from Patrickk in favor of phasTrack. Licensing updated to be compliant; objections withdrawn.

@trejjam
Copy link
Contributor

trejjam commented Oct 14, 2024

The original package is MIT. I do not see a real problem (except for some moral aspects)

@MatthewSteeples
Copy link
Contributor

The original licence file indicates that the original copyright must be present "in all copies or substantial portions of the Software".

@MatthewSteeples
Copy link
Contributor

Project has been updated now so licencing requirements are fine (cc @viceroypenguin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceroypenguin viceroypenguin viceroypenguin requested changes

@amis92 amis92 Awaiting requested review from amis92 amis92 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FXZFun @trejjam @MatthewSteeples @viceroypenguin