Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt in to receiving non-stable updates #3560

Open
wants to merge 51 commits into
base: develop
Choose a base branch
from
Open

Opt in to receiving non-stable updates #3560

wants to merge 51 commits into from

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Oct 19, 2019 •
edited by westonruter
Loading

Summary

This PR adds a plugin called "AMP Beta Tester" to opt-in to receiving updates released on GitHub.

Addresses issue #2084.

To-do:

  • Hide plugin updates if working from source
  • Force WP to do a plugin update check on plugin activation (this allows for the plugin update cache to be modified)
  • Remove any plugin data and restore plugin update cache on deactivation
  • Update plugin details to reflect that of GitHub release
  • Move plugin to the correct folder when updated
  • Add an option to control auto updating of the plugin
  • Update tests for relevant sections of code

Checklist:

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Oct 19, 2019
@pierlon pierlon force-pushed the enhancement/2084-add-opt-in-to-beta-feature branch from 060463e to 0c1cec2 Compare October 20, 2019 06:21
westonruter
westonruter reviewed Oct 20, 2019
View reviewed changes
amp-beta-tester.php Outdated Show resolved Hide resolved
@pierlon pierlon force-pushed the enhancement/2084-add-opt-in-to-beta-feature branch from 0c1cec2 to b33c78a Compare October 21, 2019 16:42
@pierlon pierlon mentioned this pull request Oct 21, 2019
Merged
@pierlon
Copy link
Contributor Author

pierlon commented Oct 22, 2019

At the moment, the plugin works as intended; that is, upgrading the AMP plugin to the latest non-stable release on GitHub. Things to note:

  • Upgrading will remove the plugin directory

  • Upgrading to 1.4.0-beta1 is not recommended, since it does not include this plugin

Regarding the failing tests, the main blocker is that files are not being required correctly due to a problem with having multiple plugin files in one directory (see PR at xwp/wp-dev-lib#307). I'm currently waiting on @kasparsd's approval so that it can get merged and released as a minor update.

kasparsd
kasparsd reviewed Oct 22, 2019
View reviewed changes
tests/php/bootstrap.php Outdated Show resolved Hide resolved
@swissspidy
Copy link
Collaborator

Upgrading to 1.4.0-beta1 is not recommended, since it does not include this plugin

When I am running the current beta / develop branch, does it even suggest upgrading to 1.4.0-beta1? If so, that sounds wrong.

swissspidy
swissspidy reviewed Oct 22, 2019
View reviewed changes
phpcs.xml Outdated Show resolved Hide resolved
swissspidy
swissspidy reviewed Oct 22, 2019
View reviewed changes
amp-beta-tester.php Outdated Show resolved Hide resolved
swissspidy
swissspidy reviewed Oct 22, 2019
View reviewed changes
amp-beta-tester.php Outdated Show resolved Hide resolved
swissspidy
swissspidy reviewed Oct 22, 2019
View reviewed changes
amp-beta-tester.php Outdated Show resolved Hide resolved
swissspidy
swissspidy reviewed Oct 22, 2019
View reviewed changes
amp-beta-tester.php Outdated Show resolved Hide resolved
@kasparsd
Copy link

@pierlon Version 1.3.0 of wp-dev-lib is out now.

@westonruter
Copy link
Member

@pierlon Version 1.3.0 of wp-dev-lib is out now.

Updated develop: #3589

swissspidy
swissspidy reviewed Oct 22, 2019
View reviewed changes
amp-beta-tester.php Outdated Show resolved Hide resolved
@pierlon pierlon force-pushed the enhancement/2084-add-opt-in-to-beta-feature branch from 7149afa to ac056eb Compare October 22, 2019 18:44
@pierlon
Copy link
Contributor Author

pierlon commented Oct 22, 2019

Upgrading to 1.4.0-beta1 is not recommended, since it does not include this plugin

When I am running the current beta / develop branch, does it even suggest upgrading to 1.4.0-beta1? If so, that sounds wrong.

@swissspidy, fixed.

@pierlon
Copy link
Contributor Author

pierlon commented Oct 22, 2019

Just to note, an update for the beta plugin will show if both the AMP and beta tester plugins are not active:

image

See #3560 (comment) as to why.

@pierlon pierlon changed the title [WIP] Opt in to a release channel Opt in to receiving non-stable updates Oct 23, 2019
@pierlon pierlon marked this pull request as ready for review October 23, 2019 07:33
@swissspidy
Copy link
Collaborator

Lots of great progress here, really awesome to see! 🎉

Just to note, an update for the beta plugin will show if both the AMP and beta tester plugins are not active:

I think the AMP Beta Tester plugin should just have the same version number as the plugin then to solve this.

swissspidy
swissspidy reviewed Oct 23, 2019
View reviewed changes
amp-beta-tester.php Outdated Show resolved Hide resolved
swissspidy
swissspidy reviewed Oct 23, 2019
View reviewed changes
amp-beta-tester.php Outdated Show resolved Hide resolved
pierlon and others added 21 commits December 9, 2019 15:40
@pierlon
Add tests for update_amp_manifest
2362169
@pierlon
Sync beta tester version with AMP
e147b1f 
Due to the WordPress Plugin Update API using the folder of the main PHP file as an identifier for updates (`amp` in this case), any other plugin file that is placed in the same folder will have the same version number as the AMP plugin.

Setting the plugin version to that of the AMP plugin or greater will solve this problem.
@pierlon @swissspidy
Use wp_doing_cron() instead of checking if DOING_CRON is defined
552b16d 
Co-Authored-By: Pascal Birchler <[email protected]>
@pierlon
Refactor pre-release regex
e6feafd 
 Check for optional patch number, and generalize the identifier for determining pre-releases as '-' would be sufficient.

 Co-Authored-By: Weston Ruter <[email protected]>
@pierlon @westonruter
Display the AMP version code as a submenu item under the top-level AM…
a670aa4 
…P admin bar menu item

Co-Authored-By: Weston Ruter <[email protected]>
@pierlon
Cache GitHub releases
1a4b2d9
@pierlon
Update plugin information used in the WP plugin API
31dc721
@pierlon
Add beta tester plugin to built release
22971f9
@pierlon
Rename folder to 'amp' upon an upgrade
3d91174
@pierlon
Bump beta tester version
a19eaeb
@pierlon
Sort releases in descending when retrieved
0645f5e
@pierlon
Rename restore_update_plugins_transient function to `remove_plugin_…
b1214ee 
…data`
@pierlon
Refactor code for updating AMP plugin update manifest
700c1e6
@pierlon
Refactor code for updating AMP plugin version details
780fa54
@pierlon
Allow plugin to be auto updated
478e6ce
@pierlon
Require a minimum WP and PHP version
6ad0294
@pierlon
Normalize constants
1b9283e
@pierlon
Make check to identify plugin to update details for more robust
4f0bc79
@pierlon
Remove unnecessary condition check when retrieving AMP plugin update …
274e958 
…manifest
@pierlon
Make anonymous functions static
871b09b
@pierlon
Remove suggestion of using PHP JSON extension as its now required
a73fbb4
@pierlon pierlon force-pushed the enhancement/2084-add-opt-in-to-beta-feature branch from 4165a25 to d6dc471 Compare December 11, 2019 06:45
@pierlon pierlon force-pushed the enhancement/2084-add-opt-in-to-beta-feature branch from d6dc471 to f757ff8 Compare December 11, 2019 07:09
@westonruter westonruter mentioned this pull request Feb 29, 2020
Closed
@schlessera schlessera added the WS:Core Work stream for Plugin core label Aug 18, 2020
@pierlon pierlon mentioned this pull request Jun 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy left review comments

@kasparsd kasparsd kasparsd left review comments

@kienstra kienstra Awaiting requested review from kienstra

@westonruter westonruter Awaiting requested review from westonruter

@schlessera schlessera Awaiting requested review from schlessera

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA WS:Core Work stream for Plugin core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pierlon @swissspidy @kasparsd @westonruter @schlessera @googlebot