Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to build script #4836

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Update references to build script #4836

merged 2 commits into from
Jun 10, 2020

Conversation

westonruter
Copy link
Member

Summary

  • Remove obsolete bin/build-plugin-zip.sh script which is no longer used.
  • Fix references to npm run build to now be npm run build:prod.

Amends #4769 for #4766.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v1.5.4 milestone Jun 10, 2020
@westonruter westonruter requested a review from pierlon June 10, 2020 21:30
@googlebot googlebot added the cla: yes Signed the Google CLA label Jun 10, 2020
@westonruter westonruter mentioned this pull request Jun 10, 2020
Merged
3 tasks
@github-actions
Copy link
Contributor

Plugin builds for e23edfe are ready 🛎️!

@westonruter westonruter merged commit 2f71508 into develop Jun 10, 2020
@westonruter westonruter deleted the update/build-script branch June 10, 2020 21:43
westonruter added a commit that referenced this pull request Jun 10, 2020
@westonruter
Update references to build script (#4836)
37fbe7d
@westonruter westonruter added the WS:Core Work stream for Plugin core label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierlon pierlon pierlon approved these changes

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA WS:Core Work stream for Plugin core
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@westonruter @pierlon @googlebot