Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conditional services referencing not-yet registered services #6784

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix conditional services referencing not-yet registered services #6784

wants to merge 1 commit into from

Conversation

schlessera
Copy link
Collaborator

Summary

This PR adds regression tests and a fix for https://github.com/ampproject/amp-wp/pull/6773/files#r767010989

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@schlessera schlessera changed the title Add tests to trigger bug Fix conditional services referencing not-yet registered services Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schlessera