-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Prometheus library #542
Conversation
Update Prometheus client library to the latest release. Signed-off-by: SuperQ <[email protected]>
Ugh, more CLAs |
Thank you Ben. |
@SuperQ Thanks for the fix! Looks like it's blocked on CLA. Is the bot busted or did you not sign? LMK if you'd prefer we submit our own fix. |
I had to find the time outside of work to read through the agreement. It seems reasonable, so I have signed it. It's far easier to use work time for projects that use a standard Linux foundation DCO. Having a CLA means if I want to use work time for a project, I have to run every single one through our lawyers. |
@SuperQ Frustration understood. I just wanted to make sure our bot wasn't stuck (and the offer to take over the PR was genuine). The choice of CLA or DCO is mostly beyond my influence (or even knowledge), but if you're curious, I recall that a discussion took place on ampproject/meta-tsc#25. Anyway, I'll merge now, thanks again! |
Thanks! One thing I noticed is that the default branch for this project isn't |
[Side note: It is confusing that |
Yes, if you make the release tags semver you can use You can also use a But I would stay at v0.1.0 or v1.0.0 for the new tags. |
Cool, thanks for the tip. Filed #544 to track this. |
Update Prometheus client library to the latest release.
Signed-off-by: SuperQ [email protected]