Skip to content

Conversation

@CalebEthridgeADI
Copy link

@CalebEthridgeADI CalebEthridgeADI commented Oct 15, 2025

PR Description

The LP512 requires the same fixups that the LP256 does, but the entry was lost during the upgrade to the new kernel. This PR adds the fixups back in, and updates the entry to match the new structure in issi.c. This fixes the current bug that is preventing the sc594 from properly probing the QSPI.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

Copy link

@UtsavAgarwalADI UtsavAgarwalADI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a commit description similar to what is there in the PR? Otherwise I think overall it makes sense and seems to be fine

Copy link

@artursartamonovsadi artursartamonovsadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on SC594 SOM RevC

The LP512 requires the same fixups that the LP256 does, but
the changes were lost on a kernel upgrade. Updating the entry
fixes the SC594 being unable to probe the QSPI.

Signed-off-by: Caleb Ethridge <[email protected]>
@CalebEthridgeADI CalebEthridgeADI force-pushed the adsp-main-6.12-fix-sc594-spiboot branch from 092d093 to 54db82b Compare October 21, 2025 06:57
@CalebEthridgeADI CalebEthridgeADI merged commit b92ba73 into adsp-main-6.12 Oct 21, 2025
1 check passed
@CalebEthridgeADI CalebEthridgeADI deleted the adsp-main-6.12-fix-sc594-spiboot branch October 21, 2025 07:00
@github-project-automation github-project-automation bot moved this to Done in ADSP Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants