projects: ADE7816: Added readme doc #2782
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvelasc2
requested review from
CiprianRegus,
amiclaus,
buha,
danmois,
dbogdan and
rbolboac
as code owners
RaduSabau1
reviewed
Oct 15, 2025
projects/ade7816/README.rst
Outdated
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| +-----------------------+-----------------------+-----------------------+ | ||
| | **Pin Function** | **EVAL-ADE7816 | **MAX32690EVKIT** | |
There was a problem hiding this comment.
For this project example AD-APARD32690-SL was used instead of MAX32690EVKIT, please apply the same change in the other occurrences as well.
RaduSabau1
reviewed
Oct 15, 2025
projects/ade7816/README.rst
Outdated
| | **Pin Function** | **EVAL-ADE7816 | **MAX32690EVKIT** | | ||
| | | Evaluation Board** | | | ||
| +-----------------------+-----------------------+-----------------------+ | ||
| | MOSI | Pin 10 (U2) - Master | Pin 45 (P3.0) - | |
There was a problem hiding this comment.
Since SPI Device 4 was used for this project, the pins are wrong for the whole SPI communication, refer to the AD-APARD32690-SL schematic for the correct pin numbers.
RaduSabau1
reviewed
Oct 15, 2025
| | CS | Pin 13 (U2) - Chip | Pin 48 (P3.3) - Chip | | ||
| | | Select (CS) | Select (CS) | | ||
| +-----------------------+-----------------------+-----------------------+ | ||
|
|
There was a problem hiding this comment.
Since this example project relies on the driver's interrupt functionality, it would be helpful to mention this hardware connection as well. Without it, the example might hang while waiting for an interrupt that does occur, but isn’t detected by the MCU due to the missing connection.
Signed-off-by: Joyce Velasco <[email protected]>
jvelasc2
force-pushed
the
ade7816-proj-readme
branch
from
56b3ea1 to
07daf82
Compare
amiclaus
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
projects: ADE7816: Added readme doc
PR Type
PR Checklist