drivers:dac:Add support for MAX22007 #2787
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansunil
force-pushed
the
max22007-dev
branch
5 times, most recently
from
9e41b68 to
e9b599b
Compare
jansunil
requested review from
CiprianRegus,
amiclaus,
buha,
danmois,
dbogdan and
rbolboac
as code owners
jansunil
force-pushed
the
max22007-dev
branch
from
e9b599b to
478f10d
Compare
amiclaus
reviewed
Oct 17, 2025
There was a problem hiding this comment.
prior to the in-depth review, please separate your commits into: driver implementation, driver documentation, project implementation, project documentation. Also the crc implementation should be in its own commit.
Example: https://github.com/analogdevicesinc/no-OS/pull/2429/commits
drivers/dac/max22007/max22007.c
Outdated
| no_os_free(dev); | ||
|
|
||
| return 0; | ||
| } No newline at end of file |
There was a problem hiding this comment.
nit: new line at the end of the file. check all files for this issue.
There was a problem hiding this comment.
I've updated the files to add a new line at the end
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
this should be builds.json. Remove the underscore _ from the filename. Otherwise it won't be parsed by the CI. Unless you have the same issue as here: df789f6
Add LSB first implementation for populating CRC table Signed-off-by: Janani Sunil <[email protected]>
jansunil
force-pushed
the
max22007-dev
branch
from
478f10d to
780861c
Compare
Add driver support for MAX22007 Signed-off-by: Janani Sunil <[email protected]>
jansunil
force-pushed
the
max22007-dev
branch
2 times, most recently
from
793dd8d to
c31703a
Compare
Add driver documentation for MAX22007 Signed-off-by: Janani Sunil <[email protected]>
Add basic example project for MAX22007 Add make based CI build support Signed-off-by: Janani Sunil <[email protected]>
Add documentation for MAX22007 example project Signed-off-by: Janani Sunil <[email protected]>
jansunil
force-pushed
the
max22007-dev
branch
from
c31703a to
26f99ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added driver, example project and documentation for MAX22007
Added a new API in the no_os_crc.c/.h to populate CRC table with LSB first logic
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist
SPI Read Operation
SPI Write Operation
