Potential fix for code scanning alert no. 1: Workflow does not contain permissions #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n permissions To fix this issue, we should add a permissions: block to the build-doc job in .github/workflows/top-level.yml, restricting the GITHUB_TOKEN to the minimum access required. Since the job only builds documentation and uploads artifacts, and does not need to push to the repository or access issues, contents: read is sufficient. This block should be added beneath runs-on: ubuntu-latest (line 9) and before the steps: block for the build-doc job. No other modification is needed. The deploy job already correctly sets its own permissions:. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/analogdevicesinc/testbenches/security/code-scanning/1
To fix this issue, we should add a
permissions:block to thebuild-docjob in.github/workflows/top-level.yml, restricting the GITHUB_TOKEN to the minimum access required. Since the job only builds documentation and uploads artifacts, and does not need to push to the repository or access issues,contents: readis sufficient. This block should be added beneathruns-on: ubuntu-latest(line 9) and before thesteps:block for thebuild-docjob. No other modification is needed. The deploy job already correctly sets its ownpermissions:.Suggested fixes powered by Copilot Autofix. Review carefully before merging.