This repository was archived by the owner on Feb 13, 2024. It is now read-only.
Open
Conversation
FLAG_SECURE prevents some applications from showing up in anbox.
|
Commenting out code, especially without an inline explanation as to why it's commented out, is really bad practice. Could you also share some examples of apps where this helps? |
Author
|
@Newbytee yeah, maybe I should add an explanation. I primarily tested it with https://github.com/gwpantazes/Flag-Secure-Sample/releases . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLAG_SECURE prevents some applications using it from showing up in anbox.
I think we should disable it for anbox because it just prevents some apps from running
and doesn't offer an actual benefit for us.
Here is a patch for that.