Changing the makefile for a better definition of the prefix, added 2 new color definitions for theme using 2 colors for colums, which collided with the help file #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a color for the help text, because the default caused with a dual color col config issues.
The makefile can now include an optional file local.mk to define the prefix which is ignored by git. The help was updated with the new color definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a theme with a color for odd and even columns, which demanded the use of NONE_COLOR for DEFAULT. But this made it impossible to get a good color definition for help, since help is using DEFAULT. Instead of changing the drawing order, I added 2 color definitions HELP_TEXT and HELP_KEYDEF to the code, which makes more sense to have full control. The file doc was updated as well.
To avoid a change of prefix in the Makefile is changing the repo, I changed the Makefile so that an optional file local.mk is included to define the prefix. The file local.mk is ignored by git.