Skip to content

Conversation

@JolandaVerhoef
Copy link
Collaborator

Omitting them can cause problematic behavior in some of the backend models.

…atic behavior in some of the backend models.

Change-Id: I9c54234bdba922b918ce5eee3fba52d953fc7bcb
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses potential problematic behavior in backend models by ensuring that function call identifiers are correctly propagated within the Live Todo sample application. By including the functionCall.id in all FunctionResponsePart instances, the system's interaction with generative AI models is made more robust and reliable, preventing issues that could arise from their omission.

Highlights

  • Function ID Integration: The functionCall.id is now consistently passed as an argument to the FunctionResponsePart constructor across all handled functions (getTodo, addTodo, removeTodo, toggleTodo, and default cases) within the TodoScreenViewModel.
  • Model Configuration Comments: Alternative Gemini Live model configurations (gemini-live-2.5-flash-preview and gemini-2.5-flash-native-audio-preview-09-2025) have been commented out in the TodoScreenViewModel.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the required functionCall.id to FunctionResponsePart constructions. My review includes a suggestion to refactor the handleFunctionCall method to improve its maintainability by reducing code duplication and to enhance its robustness by safely handling potentially missing function call arguments, which currently could lead to crashes.

Change-Id: I9c13ae5eb448a540a5bee970ed7d74add2531459
// "gemini-live-2.5-flash-preview", // available through googleAI(), to be deprecated on Dec 9th 2025.
// "gemini-2.0-flash-live-001", // available through googleAI(), to be deprecated on Dec 9th 2025.
// "gemini-2.0-flash-live-preview-04-09", // available through vertexAI()
// "gemini-live-2.5-flash-preview-native-audio-09-2025", // available through vertexAI()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just remove them and link to the Firebase doc instead.

Change-Id: I854be3c2bd9f19ca913ffb246e88529d01098a47
@JolandaVerhoef JolandaVerhoef merged commit 7ca0bca into main Nov 17, 2025
3 checks passed
@JolandaVerhoef JolandaVerhoef deleted the jv/function_ids branch November 17, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants