-
Notifications
You must be signed in to change notification settings - Fork 113
Add function ids to Live Todo sample. #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…atic behavior in some of the backend models. Change-Id: I9c54234bdba922b918ce5eee3fba52d953fc7bcb
Summary of ChangesHello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses potential problematic behavior in backend models by ensuring that function call identifiers are correctly propagated within the Live Todo sample application. By including the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds the required functionCall.id to FunctionResponsePart constructions. My review includes a suggestion to refactor the handleFunctionCall method to improve its maintainability by reducing code duplication and to enhance its robustness by safely handling potentially missing function call arguments, which currently could lead to crashes.
...mini-live-todo/src/main/java/com/android/ai/samples/geminilivetodo/ui/TodoScreenViewModel.kt
Outdated
Show resolved
Hide resolved
...mini-live-todo/src/main/java/com/android/ai/samples/geminilivetodo/ui/TodoScreenViewModel.kt
Outdated
Show resolved
Hide resolved
Change-Id: I9c13ae5eb448a540a5bee970ed7d74add2531459
| // "gemini-live-2.5-flash-preview", // available through googleAI(), to be deprecated on Dec 9th 2025. | ||
| // "gemini-2.0-flash-live-001", // available through googleAI(), to be deprecated on Dec 9th 2025. | ||
| // "gemini-2.0-flash-live-preview-04-09", // available through vertexAI() | ||
| // "gemini-live-2.5-flash-preview-native-audio-09-2025", // available through vertexAI() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just remove them and link to the Firebase doc instead.
Change-Id: I854be3c2bd9f19ca913ffb246e88529d01098a47
Omitting them can cause problematic behavior in some of the backend models.