Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to removed obsolete sample projects. #1474

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

p-m-j
Copy link

@p-m-j p-m-j commented Sep 26, 2024

I found it quite frustrating to be reading / watching training content that made reference to the Jetsurvey project in this repo only to find it no longer exists. I imagine this would be even more frustating for those going through learning materials alongside learning git.

@p-m-j p-m-j requested a review from a team as a code owner September 26, 2024 16:09
Copy link

google-cla bot commented Sep 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@IanGClifton IanGClifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for adding the links!

README.md Outdated Show resolved Hide resolved
@IanGClifton
Copy link
Contributor

Rebecca, can you verify these are the right hashes/links we want to use to point people to the projects we've removed?

Copy link
Collaborator

@riggaroo riggaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! You just need to sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants