refactor: use object theme to optimize sub system management#1808
Open
jelychow wants to merge 4 commits intoandroid:mainfrom
Open
refactor: use object theme to optimize sub system management#1808jelychow wants to merge 4 commits intoandroid:mainfrom
jelychow wants to merge 4 commits intoandroid:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using object to encapsulate the theme subsystem
DO NOT CREATE A PULL REQUEST WITHOUT READING THESE INSTRUCTIONS
Instructions
No more material themes in apps, this avoids importing different styles so that the theme is always presented as we expect it to be.
colors:NiaTheme.colorScheme.background
custom background:NiaTheme.niaBackground.background
gradient: NiaTheme.gradientColors
If this is your first pull request
Ensure tests pass and code is formatted correctly
DemoDebugvariant by running./gradlew testDemoDebug./gradlew --init-script gradle/init.gradle.kts spotlessApplyAdd a description
Using object to manage Theme's subsystems makes it easier to use them instead of using them directly inside the repo, which violates encapsulation.
NOW DELETE THIS LINE AND EVERYTHING ABOVE IT
What I have done and why
use NiaTheme instead of MaterialTheme
use properties instead of directly using sub systems