Open
Conversation
- Use BOM platform dependency. - Remove -kt suffix from dependency name has they serve no real purpose. - Add `coil-network` artifact to configure `CallFactory`. - Although "First party Decoder" `SvgDecoder` is now automatically added to each new ImageLoader through a service loader, keeping it in code prevents us from removing the dependency that would appear unused otherwise. - Replace explicit `respectCacheHeaders(false)` with `CacheStrategy::DEFAULT` which does not respect cache-control headers. - Migrate `ImageLoaderFactory` to `SingletonImageLoader.Factory` - Inline TOML dependencies (see android#1856) docs: https://coil-kt.github.io/coil/upgrading_to_coil3/
…ckException ``` Roborazzi: Error: [AccessibilityViewCheckResult check=AccessibilityHierarchyCheckResult ERROR SpeakableTextPresentCheck 4 [ViewHierarchyElement class=android.view.View testTag=newsResourceCard:3 bounds=Rect(1058, 2126 - 1947, 2523)] null num_answers:0 view=null] ```
SimonMarquis
commented
Apr 5, 2025
| // Pass null for action to only override the label and not the actual action. | ||
| modifier = modifier | ||
| .semantics { | ||
| contentDescription = clickActionLabel |
Contributor
Author
There was a problem hiding this comment.
Let me know if you prefer to use userNewsResource.title or if another workaround might be better (adding a header semantic somewhere in the card maybe?)
SimonMarquis
force-pushed
the
migration-coil2-coil3
branch
from
ed1c1df to
d4df5c8
Compare
Contributor
Author
|
@dturner please take a look at this migration PR when you have time. It is a pretty straightforward migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coil-networkartifact to configureCallFactory.SvgDecoderis now automatically added to each new ImageLoader through a service loader, keeping it in code prevents us from removing the dependency that would appear unused otherwise.respectCacheHeaders(false)withCacheStrategy::DEFAULTwhich does not respect cache-control headers.ImageLoaderFactorytoSingletonImageLoader.Factorydocs: https://coil-kt.github.io/coil/upgrading_to_coil3/