Skip to content

Conversation

@amyZepp
Copy link
Contributor

@amyZepp amyZepp commented Jan 5, 2026

Adding a snippet for Jetpack Scenecore material overrides in XR

@amyZepp amyZepp requested a review from a team as a code owner January 5, 2026 19:40
@snippet-bot
Copy link

snippet-bot bot commented Jan 5, 2026

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @amyZepp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new code snippet aimed at guiding developers on implementing material overrides within Jetpack Scenecore for XR environments. It provides practical, self-contained examples for creating and customizing KhronosPbrMaterial instances, applying various textures, and managing these overrides on GLTF model entities, thereby enhancing the visual flexibility and customization options available in XR applications.

Highlights

  • New Snippet for Material Overrides: A new Kotlin file, MaterialOverride.kt, has been added to provide code snippets demonstrating how to manage material overrides in Jetpack Scenecore for XR applications.
  • KhronosPbrMaterial Usage: The snippet includes examples for creating a KhronosPbrMaterial with specific alpha modes and customizing its properties, such as setting the base color factor.
  • Texture and Occlusion Management: It illustrates how to create textures from file paths and apply them as occlusion textures to KhronosPbrMaterial instances.
  • GLTF Model Entity Integration: The new code provides functions to apply and clear material overrides on specific nodes within a GltfModelEntity, offering granular control over model appearance.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new file with code snippets for Jetpack Scenecore material overrides. The overall structure is good for providing documentation snippets. I've found a few areas for improvement. Specifically, some functions create objects but don't use them, which can be confusing in an example. I've suggested assigning them to variables to make the snippets more practical. There's also an issue in setMaterialOverride where a redundant let block and a misplaced snippet end tag would lead to a broken code snippet. I've provided a suggestion to simplify the code and fix the snippet generation. These changes will improve the quality and correctness of the code examples.

@devbridie devbridie enabled auto-merge (squash) January 6, 2026 11:14
@devbridie devbridie self-requested a review January 6, 2026 11:15
Copy link
Contributor

@vad710 vad710 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devbridie devbridie merged commit a935e3a into main Jan 6, 2026
6 checks passed
@devbridie devbridie deleted the xr_material_updates branch January 6, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants