Added DST rules for Western Europe and Australia#3
Open
Gambalunga wants to merge 12 commits intoandydoro:masterfrom
Open
Added DST rules for Western Europe and Australia#3Gambalunga wants to merge 12 commits intoandydoro:masterfrom
Gambalunga wants to merge 12 commits intoandydoro:masterfrom
Conversation
Added Australian DST Changed const char rulesDST[] to char rulesDST[]
Added DST rules for Australia
Added DST rules for Australia and other small improvements
Small improvements to the code
Added a new set of rules for Western Europe (UK, Ireland and Portugal)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have further modified the library with a few changes and the addition of the DST rules for Australia.
In the logic for the change of DST I have eliminated, to a large degree the use of previousSunday using RTCTime.day() instead. It does not make any difference really but, in my opinion makes it more comprehensible. In some cases the use of previousSunday is still logical.
I have also changed the use of extern const char rulesDST[] to extern char rulesDST[]
This change allows me to vary the DST zone within the program by a user setting. A constant has no particular purpose in this case.
I have extensively tested the code but before publishing it I would suggest that you also test it. Obviously any logic errors can be corrected if someone lets me know of them.
Note that Great Britain, Ireland and Portugal change time at 1:00 AM local time not at 2:00 AM local time as in most of Europe.