Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/ssr): prevent stream draining if write does not return a boolean #29804

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

alan-agius4
Copy link
Collaborator

Implements a workaround for CodeGenieApp/serverless-express#683

Closes #29801

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release and removed area: @angular/ssr labels Mar 11, 2025
@alan-agius4 alan-agius4 requested a review from clydin March 11, 2025 12:02
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 11, 2025
@alan-agius4 alan-agius4 merged commit ee8466d into angular:main Mar 11, 2025
35 checks passed
@alan-agius4 alan-agius4 deleted the ssr-drain branch March 11, 2025 14:24
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@angular/ssr - node drain breaks serverless
2 participants