Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve resilience of asset timestamp E2E test #29934

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 25, 2025

The test now uses an asset that is already on disk.
Using an asset that was just written within the test
may cause timestamps to not yet be synced to disk.

@clydin clydin force-pushed the application/assets-node-cp branch from 7e6972a to bbf7f75 Compare March 25, 2025 20:59
The test now uses an asset that is already on disk.
Using an asset that was just written within the test
may cause timestamps to not yet be synced to disk.
@clydin clydin force-pushed the application/assets-node-cp branch from bbf7f75 to 996ff17 Compare March 25, 2025 21:42
@clydin clydin marked this pull request as ready for review March 25, 2025 21:42
@clydin clydin added the target: major This PR is targeted for the next major release label Mar 25, 2025
@clydin clydin requested a review from alan-agius4 March 25, 2025 21:54
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 25, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 26, 2025
@alan-agius4 alan-agius4 merged commit 1f62b28 into angular:main Mar 26, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants