Skip to content

feat(@schematics/angular): Add global error listeners to new app generation #30053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Apr 7, 2025

This commit adds the provider for global error listener in the browser. This is particularly useful for zoneless apps but also useful for Zone-based applications when errors happen outside the Angular zone.

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: @schematics/angular labels Apr 7, 2025
@atscott atscott force-pushed the errorlisteners branch 3 times, most recently from ff0ccd0 to 8b6b222 Compare April 16, 2025 23:12
@atscott atscott marked this pull request as ready for review April 16, 2025 23:24
@atscott atscott requested a review from alan-agius4 April 17, 2025 16:20
@atscott atscott added the target: minor This PR is targeted for the next minor release label Apr 17, 2025
@atscott atscott added this to the v20 Candidates milestone Apr 17, 2025
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 22, 2025
@atscott atscott requested a review from alan-agius4 April 22, 2025 17:29
@atscott atscott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 22, 2025
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 23, 2025
…ration

This commit adds the provider for global error listener in the browser.
This is particularly useful for zoneless apps but also useful for
Zone-based applications when errors happen outside the Angular zone.
@alan-agius4 alan-agius4 merged commit e03f2b8 into angular:main Apr 23, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants