Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs-infra): add support for @example #60443

Closed
wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Mar 18, 2025

In TSDoc, we currently handle the @usageNotes annotation, but this is not a standard TSDoc tag. Instead, the @example annotation is the correct standard, which is used in the Angular CLI repo and on the SSR package.

This change ensures that @example is treated the same as @usageNotes during the transform process and also handle multiple instances of @example on the same tag.

Example
Screenshot 2025-03-18 at 15 15 41

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 18, 2025
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Mar 18, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 18, 2025
In TSDoc, we currently handle the `@usageNotes` annotation, but this is not a standard TSDoc tag. Instead, the `@example` annotation is the correct standard, which is used in the Angular CLI repo and on the SSR package.

This change ensures that `@example` is treated the same as `@usageNotes` during the transform process and also handle multiple instances of `@example` on the same tag.
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker adev: preview and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 18, 2025
Copy link

Deployed adev-preview for 53c0321 to: https://ng-dev-previews-fw--pr-angular-angular-60443-adev-prev-rxhvj2g1.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 8e48bc9.

The changes were merged into the following branches: main, 19.2.x

pkozlowski-opensource pushed a commit that referenced this pull request Mar 18, 2025
In TSDoc, we currently handle the `@usageNotes` annotation, but this is not a standard TSDoc tag. Instead, the `@example` annotation is the correct standard, which is used in the Angular CLI repo and on the SSR package.

This change ensures that `@example` is treated the same as `@usageNotes` during the transform process and also handle multiple instances of `@example` on the same tag.

PR Close #60443
@alan-agius4 alan-agius4 deleted the usage-notes-adev branch March 18, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants