refactor(docs-infra): remove redundant overrides in FakeWebContainer
#60581
+21
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
angular-robot
bot
added
the
area: docs-infra
This is required to fix
```
adev/shared-docs/testing/testing-helper.ts:100:12 - error TS2416: Property 'on' in type 'FakeWebContainer' is not assignable to the same property in base type 'WebContainer'.
Type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; }' is not assignable to type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "xdg-open", listener: OpenListener): Unsubscribe; (ev...'.
Types of parameters 'event' and 'event' are incompatible.
Type '"xdg-open"' is not assignable to type '"port"'.
100 override on(event: 'server-ready', listener: ServerReadyListener): Unsubscribe;
~~
```
See: https://github.com/angular/angular/actions/runs/14098789522/job/39491059550?pr=60526
alan-agius4
force-pushed
the
refactor-testing-helpers
branch
from
03b2665 to
1efee45
Compare
Modernize code of testing-helper
devversion
approved these changes
Mar 27, 2025
alan-agius4
added
action: merge
thePunderWoman
pushed a commit
that referenced
this pull request
Mar 27, 2025
Modernize code of testing-helper PR Close #60581
thePunderWoman
pushed a commit
that referenced
this pull request
Mar 27, 2025
#60581) This is required to fix ``` adev/shared-docs/testing/testing-helper.ts:100:12 - error TS2416: Property 'on' in type 'FakeWebContainer' is not assignable to the same property in base type 'WebContainer'. Type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; }' is not assignable to type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "xdg-open", listener: OpenListener): Unsubscribe; (ev...'. Types of parameters 'event' and 'event' are incompatible. Type '"xdg-open"' is not assignable to type '"port"'. 100 override on(event: 'server-ready', listener: ServerReadyListener): Unsubscribe; ~~ ``` See: https://github.com/angular/angular/actions/runs/14098789522/job/39491059550?pr=60526 PR Close #60581
thePunderWoman
pushed a commit
that referenced
this pull request
Mar 27, 2025
Modernize code of testing-helper PR Close #60581
|
This PR was merged into the repository by commit 9e8a1c9. The changes were merged into the following branches: main, 19.2.x |
mattrberry
pushed a commit
to mattrberry/angular
that referenced
this pull request
Mar 28, 2025
angular#60581) This is required to fix ``` adev/shared-docs/testing/testing-helper.ts:100:12 - error TS2416: Property 'on' in type 'FakeWebContainer' is not assignable to the same property in base type 'WebContainer'. Type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; }' is not assignable to type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "xdg-open", listener: OpenListener): Unsubscribe; (ev...'. Types of parameters 'event' and 'event' are incompatible. Type '"xdg-open"' is not assignable to type '"port"'. 100 override on(event: 'server-ready', listener: ServerReadyListener): Unsubscribe; ~~ ``` See: https://github.com/angular/angular/actions/runs/14098789522/job/39491059550?pr=60526 PR Close angular#60581
mattrberry
pushed a commit
to mattrberry/angular
that referenced
this pull request
Mar 28, 2025
Modernize code of testing-helper PR Close angular#60581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to fix
See: https://github.com/angular/angular/actions/runs/14098789522/job/39491059550?pr=60526