Skip to content

fix(bazel): handle *.mts / *.cts extensions in strict deps test #2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dgp1130
Copy link
Contributor

@dgp1130 dgp1130 commented Apr 15, 2025

Encountered a strict deps error in angular/angular-cli#30036 and noticed that my usage of *.mts files wasn't working properly.

@dgp1130 dgp1130 requested a review from devversion April 15, 2025 22:39
@dgp1130 dgp1130 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 15, 2025
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 16, 2025
@josephperrott josephperrott removed the request for review from devversion April 16, 2025 00:57
@josephperrott
Copy link
Member

This PR was merged into the repository by commit 22a5713.

The changes were merged into the following branches: main

@dgp1130 dgp1130 deleted the strict-deps branch April 16, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants