Skip to content
This repository was archived by the owner on Nov 3, 2026. It is now read-only.

fix: do not silently fail puppeteer testing - #194

Merged
devversion merged 1 commit into
angular:mainfrom
devversion:screenshot-errors
Dec 3, 2025
Merged

devversion merged 1 commit into
angular:mainfrom
devversion:screenshot-errors

Conversation

@devversion

Copy link
Copy Markdown
Member

We currently catch errors for Puppeteer logic (screenshot, runtime error collection, CSP testing etc.). The error message logged is actually wrongly saying something about screenshots.

In addition, we don't even report the error back to the worker "host". This means that the error is simply swallowed and there is empty serve testing result. We should surface the error properly by removing the try/catch and letting the try/catch in worker.ts catch the error --> so that it sets the serveTestingResult#errorMessage.

We currently catch errors for Puppeteer logic (screenshot, runtime error
collection, CSP testing etc.). The error message logged is actually
wrongly saying something about screenshots.

In addition, we don't even report the error back to the worker "host".
This means that the error is simply swallowed and there is empty serve
testing result. We should surface the error properly by removing the
`try/catch` and letting the try/catch in `worker.ts` catch the error -->
so that it sets the `serveTestingResult#errorMessage`.

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devversion
devversion merged commit 3598cdc into angular:main Dec 3, 2025
3 checks passed
@devversion
devversion deleted the screenshot-errors branch December 3, 2025 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants