fix(java): resolve maven pom property placeholders in parent coords#234
Merged
Conversation
Dependency versions like `${project.version}` leaked into reports as literal placeholders, and a parent declared with a CI-friendly `${revision}` version produced a bogus Maven Central URL, so the license lookup fell back to Unknown instead of following the parent chain.
Property resolution now includes the Maven built-in `project.*` properties derived from the POM's own and parent coordinates (following Maven's inheritance rules), so sibling-module deps versioned as `${project.version}` resolve in scans and in the transitive walk. Parent coordinates are property-resolved before fetching, and when the parent version stays unresolvable (`${revision}` defined only in the parent POM itself) it falls back to the child's own version, which such reactors share; a wrong guess just fails the fetch, which is where the raw placeholder ended up anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency versions like
${project.version}leaked into reports as literal placeholders, and a parent declared with a CI-friendly${revision}version produced a bogus Maven Central URL, so the license lookup fell back to Unknown instead of following the parent chain.Property resolution now includes the Maven built-in
project.*properties derived from the POM's own and parent coordinates (following Maven's inheritance rules), so sibling-module deps versioned as${project.version}resolve in scans and in the transitive walk. Parent coordinates are property-resolved before fetching, and when the parent version stays unresolvable (${revision}defined only in the parent POM itself) it falls back to the child's own version, which such reactors share; a wrong guess just fails the fetch, which is where the raw placeholder ended up anyway.