Improve synchronization process when no pull request is needed - #20896
Conversation
|
Could this be tested? |
|
Yes, I can test it running workflow on my fork. I'll temporarily use |
60f466c to
a224b38
Compare
112e301 to
aacb745
Compare
@david-allison I'm sorry for confusion. I really took screenshot from my own fork Action tab and I definitely didn't take from Google images. I used Checks API to create a neutral status, which is why its appeared that in testing |
Should i stick with Checks API for neutral status(current approach) or switch to |
|
I know the screenshot was yours, I checked and I saw the effort you put in, it's truly appreciated. I strongly suspect it won't be possible, so let's go with another approach:
Whatever you do will be better than what we have now, and it's truly appreciated! |
d625a03 to
a0986e1
Compare
@david-allison I have tested the step summary approach on my fork. You can check it out in the screenshot |
|
Windows test failure seems unrelated to my code changes |
Have you tested this? If no, then try running unit tests without your code changes. Saying this because I highly doubt that earlier commits would not have been accepted without all unit tests passing. |
|
Unit tests were flaky. |
0aa46ca to
e4a0f5e
Compare
|
@david-allison I updated the code. See if you like it |
david-allison
left a comment
There was a problem hiding this comment.
This is excellent, thank you!
e4a0f5e to
4923752
Compare
4923752 to
45a4ae9
Compare
mikehardy
left a comment
There was a problem hiding this comment.
Thanks! In general I like the idea / the purpose of the PR - definitely needs a different take on the conflict resolution, and an idea on compacting the implementation tho
45a4ae9 to
5275dee
Compare
|
@mikehardy I've updated the code. Please see if this is the compact implementation you were looking for |
|
@mikehardy Could you please review the updated code when you have time ? |
mikehardy
left a comment
There was a problem hiding this comment.
seems good to go now, thank you!




Note
Syntax research for the GitHub API was assisted by Gemini-3-flash
Purpose / Description
I fixed the translation sync workflow so it doesn't error out when there aren't any string to update
Fixes
Approach
I used
github-scriptto check for staged changes and manually trigger a neutral check result via the GitHub API if the tree is cleanChecklist