feat(card-browser): implement 'Default search text' - #20955
Open
david-allison wants to merge 4 commits into
Open
feat(card-browser): implement 'Default search text'#20955david-allison wants to merge 4 commits into
david-allison wants to merge 4 commits into
Conversation
Contributor
|
LGTM - has a merge conflict to resolve. |
david-allison
force-pushed
the
18618-default-search-text
branch
from
May 17, 2026 13:07
1459d99 to
d9832f5
Compare
Contributor
|
Snapshot diff report vs
All 1 changed screenshotsPreferencesScreenshotTest
|
david-allison
force-pushed
the
18618-default-search-text
branch
from
May 27, 2026 16:03
d9832f5 to
2ead9ab
Compare
david-allison
force-pushed
the
18618-default-search-text
branch
from
June 3, 2026 04:19
2ead9ab to
bb13c66
Compare
david-allison
force-pushed
the
18618-default-search-text
branch
from
June 12, 2026 07:47
bb13c66 to
c46d95a
Compare
* Simplifies the ViewModel, it's getting large Assisted-by: Claude Opus 4.7 - all
Assisted-by: Claude Opus 4.7 - all
Fixes 18618 Assisted-by: Claude Opus 4.7 - all
android:textColorHint was #79747E. On #E4F5FD this led to a contrast of 4.07:1 #716C76 is 4.57:1 - acceptable for text Assisted-by: Claude Opus 4.7 - color
david-allison
force-pushed
the
18618-default-search-text
branch
from
June 14, 2026 21:37
c46d95a to
1922ed6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.7
Purpose / Description
Upstream functionality, only implemented in the new card browser
Fixes
Approach
I performed a few initial refactors, partially as logic shouldn't be in the
saveChangesmethod, partially to reduce the code in the ViewModelHow Has This Been Tested?
Unit tests
Checklist