Skip to content

fix: Night mode theme changes when opening settings - #20969

Merged
david-allison merged 4 commits into
ankidroid:mainfrom
BrayanDSO:fix/theme
May 8, 2026
Merged

fix: Night mode theme changes when opening settings#20969
david-allison merged 4 commits into
ankidroid:mainfrom
BrayanDSO:fix/theme

Conversation

@BrayanDSO

Copy link
Copy Markdown
Member

Fixes

How Has This Been Tested?

Unit tests

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

BrayanDSO added 3 commits May 7, 2026 05:58
made sense in the past, but not now
`all default values match the preference XMLs` wasn't working correctly, so bugs like 20966 happened

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much!!

@david-allison david-allison added Queued for Cherry Pick to Stable Branch Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 7, 2026
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 8, 2026
@lukstbit
lukstbit added this pull request to the merge queue May 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 8, 2026
@david-allison
david-allison added this pull request to the merge queue May 8, 2026
Merged via the queue into ankidroid:main with commit e3690dd May 8, 2026
19 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone May 8, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 8, 2026
@mikehardy mikehardy modified the milestones: 2.25 release, 2.24.1 release Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Night mode theme changes when opening settings

5 participants