Skip to content

test: screenshot test for all activities - #20975

Merged
BrayanDSO merged 1 commit into
ankidroid:mainfrom
david-allison:screenshot-test-1
May 8, 2026
Merged

test: screenshot test for all activities#20975
BrayanDSO merged 1 commit into
ankidroid:mainfrom
david-allison:screenshot-test-1

Conversation

@david-allison

Copy link
Copy Markdown
Member

Assisted-by: Claude Opus 4.7 - all

Purpose / Description

Approach

The same pattern as ActivityStartupUnderBackupTest

How Has This Been Tested?

./gradlew :AnkiDroid:recordRoborazziPlayDebug -Pscreenshot --tests "com.ichi2.anki.AllActivitiesScreenshotTest"

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

abstract class ScreenshotTest : RobolectricTest() {
/** Pixel-class phone in portrait, light theme. */
protected fun setPhoneQualifiers() {
RuntimeEnvironment.setQualifiers("w411dp-h914dp-notnight-420dpi")

@BrayanDSO BrayanDSO May 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially got this from RobolectricDeviceQualifiers.MediumPhone and RobolectricDeviceQualifiers.MediumTablet

Had to use strings in StudyScreenScreenshotTest to parameterize it

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 8, 2026
Prep for edge to edge: 17334

Assisted-by: Claude Opus 4.7 - all
@BrayanDSO
BrayanDSO added this pull request to the merge queue May 8, 2026
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 8, 2026
Merged via the queue into ankidroid:main with commit 11838b5 May 8, 2026
19 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in AnkiDroid 2.25 May 8, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 8, 2026
@github-actions github-actions Bot added this to the 2.25 release milestone May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants