Skip to content

fix(note-editor): MathJax Block - #20977

Merged
lukstbit merged 3 commits into
ankidroid:mainfrom
david-allison:mathjax
May 23, 2026
Merged

fix(note-editor): MathJax Block#20977
lukstbit merged 3 commits into
ankidroid:mainfrom
david-allison:mathjax

Conversation

@david-allison

@david-allison david-allison commented May 7, 2026

Copy link
Copy Markdown
Member

Note

Assisted-by: Claude Opus 4.7

Purpose / Description

Was: \[\\]
Now: \[\]

Fixes

How Has This Been Tested?

Unit tested

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@Giyutomioka-SS

Giyutomioka-SS commented May 15, 2026

Copy link
Copy Markdown
Contributor

LGTM. Clean fix 🚀

BrayanDSO
BrayanDSO approved these changes May 18, 2026
View reviewed changes
Comment thread AnkiDroid/src/main/java/com/ichi2/anki/noteeditor/MathJaxFormat.kt Outdated
Comment thread AnkiDroid/src/test/java/com/ichi2/anki/noteeditor/MathJaxFormatTest.kt Outdated
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 18, 2026
@david-allison
fix(note-editor): MathJax Block
8a4f6be 
Was: `\[\\]`
Now: `\[\]`

Fixes 20961
@david-allison
docs(note-editor): improve TextWrapper docs
7dc3a6a
@david-allison
refactor(note-editor): make MathJax testable
2b6437c 
Issue 20961

Assisted-by: Claude Opus 4.7 - most of the code
@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • PreferencesScreenshotTest: 1 change
All 1 changed screenshots

PreferencesScreenshotTest

  • ReviewerOptionsFragment_compare.png

@BrayanDSO BrayanDSO mentioned this pull request May 18, 2026
Open
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 23, 2026
@lukstbit
lukstbit added this pull request to the merge queue May 23, 2026
Merged via the queue into ankidroid:main with commit a03732f May 23, 2026
23 of 24 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone May 23, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 23, 2026
@david-allison
david-allison deleted the mathjax branch May 23, 2026 09:09
@mikehardy mikehardy modified the milestones: 2.25 release, 2.24.1 release Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukstbit lukstbit lukstbit approved these changes
@BrayanDSO BrayanDSO BrayanDSO approved these changes

Assignees

No one assigned

Labels

Cherry Picked to Stable Branch

Projects

None yet

Milestone

2.24.1 release

Development

Successfully merging this pull request may close these issues.

MathJax block button adds an extra backslash: \[\\]

5 participants

@david-allison @Giyutomioka-SS @lukstbit @BrayanDSO @mikehardy