Skip to content

fix(card-browser): error message when entering 'and' - #20999

Merged
lukstbit merged 2 commits into
ankidroid:mainfrom
david-allison:r8-demangle
May 15, 2026
Merged

fix(card-browser): error message when entering 'and'#20999
lukstbit merged 2 commits into
ankidroid:mainfrom
david-allison:r8-demangle

Conversation

@david-allison

@david-allison david-allison commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Note

Assisted-by: Claude Opus 4.7 - test

Purpose / Description

  • Exception class names were mangled
  • Exception class names were shown

Fixes

Approach

  • proguard rule
  • special-case libanki InvalidSearchException

How Has This Been Tested?

Unit tested

API 37 emulator

Screenshot 2026-05-08 at 15 00 08

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@ZornHadNoChoice

This comment was marked as resolved.

Sign in to view
@david-allison david-allison changed the title fix)card-browser): error message when entering 'and' fix(card-browser): error message when entering 'and' May 8, 2026
@david-allison

david-allison commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

The dialog looks weird.

That's the dialog with the 'OK' button focused - I believe API 37 is still in beta, or I have a beta emulator

[There's a typo in the title and the AI callout is a quote.]

Fixed, cheers!

BrayanDSO
BrayanDSO reviewed May 10, 2026
View reviewed changes
Comment thread AnkiDroid/proguard-rules.pro
@david-allison
fix(card-browser): improve search error message
5b2515c 
The message already starts with 'invalid search'

So we do not need to show the exception name(s)

Fixes 20998

Assisted-by: Claude Opus 4.7 - test
@david-allison
david-allison requested a review from BrayanDSO May 11, 2026 01:13
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 11, 2026
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 15, 2026
@lukstbit
lukstbit added this pull request to the merge queue May 15, 2026
Merged via the queue into ankidroid:main with commit 494e9d1 May 15, 2026
19 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone May 15, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 15, 2026
@mikehardy mikehardy modified the milestones: 2.25 release, 2.24.1 release Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukstbit lukstbit lukstbit approved these changes
@BrayanDSO BrayanDSO BrayanDSO approved these changes

Assignees

No one assigned

Labels

Cherry Picked to Stable Branch

Projects

None yet

Milestone

2.24.1 release

Development

Successfully merging this pull request may close these issues.

Card Browser: 'InvalidSearchException' message formatting R8 mangles exception names [Browser] bad error messages

5 participants

@david-allison @ZornHadNoChoice @lukstbit @BrayanDSO @mikehardy