Skip to content

test: preferences fragments screenshots - #21005

Merged
BrayanDSO merged 2 commits into
ankidroid:mainfrom
BrayanDSO:test/prefs
May 10, 2026
Merged

test: preferences fragments screenshots#21005
BrayanDSO merged 2 commits into
ankidroid:mainfrom
BrayanDSO:test/prefs

Conversation

@BrayanDSO

Copy link
Copy Markdown
Member

go go screenshot tests

How Has This Been Tested?

./gradlew :AnkiDroid:recordRoborazziPlayDebug -Pscreenshot --tests "com.ichi2.anki.preferences.PreferencesScreenshotTest"

image

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@@ -0,0 +1,34 @@
// SPDX-License-Identifier: GPL-3.0-or-later

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do I still need to add my copyright? @david-allison

@david-allison david-allison May 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending a decision/discussion/issue.

Leave them on to be safe. Push the decision forward if you wish (I'd also rather remove them).

https://reuse.software/tutorial/ requires both tags.

The Kernel doesn't have this requirement. I don't think REUSE is beneficial for us, but leaving copyright tags on now is much easier than applying them later if we change course.

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending copyright

@BrayanDSO
BrayanDSO enabled auto-merge May 10, 2026 21:55
@BrayanDSO
BrayanDSO added this pull request to the merge queue May 10, 2026
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels May 10, 2026
Merged via the queue into ankidroid:main with commit 8206637 May 10, 2026
19 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone May 10, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants