Skip to content

test: device and theme screenshot properties - #21007

Merged
criticalAY merged 1 commit into
ankidroid:mainfrom
BrayanDSO:test/screen-properties
May 12, 2026
Merged

test: device and theme screenshot properties#21007
criticalAY merged 1 commit into
ankidroid:mainfrom
BrayanDSO:test/screen-properties

Conversation

@BrayanDSO

@BrayanDSO BrayanDSO commented May 9, 2026

Copy link
Copy Markdown
Member

global properties to run tests with a tablet frame and/or dark theme

It also sets the MediumPhone qualifier by default, so tests like AllActivitiesScreenshotTest don't need to set it manually

add -Ptheme=dark to use dark theme and -Pdevice=tablet to use a tablet frame

How Has This Been Tested?

./gradlew :AnkiDroid:recordRoborazziPlayDebug -Pscreenshot -Ptheme=dark

./gradlew :AnkiDroid:recordRoborazziPlayDebug -Pscreenshot -Pdevice=tablet

./gradlew :AnkiDroid:recordRoborazziPlayDebug -Pscreenshot -Ptheme=dark -Pdevice=tablet

image

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

add -Ptheme=dark to use dark theme and -Pdevice=tablet to use a tablet frame
@BrayanDSO
BrayanDSO force-pushed the test/screen-properties branch from b69fcf7 to 8cabe3b Compare May 9, 2026 14:21
@BrayanDSO
BrayanDSO requested a review from david-allison May 9, 2026 14:25

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 9, 2026

@criticalAY criticalAY left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou!

@criticalAY criticalAY added the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 12, 2026
@criticalAY
criticalAY added this pull request to the merge queue May 12, 2026
Merged via the queue into ankidroid:main with commit b160855 May 12, 2026
19 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone May 12, 2026
@github-actions github-actions Bot removed Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) Needs Second Approval Has one approval, one more approval to merge labels May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants