fix(scheduler): 'deck not found in limits map'

[david-allison]

Note

Assisted-by: Claude Opus 4.7 - initial debugging, wrote code which I designed

Fixes

• Fixes "deck not found in limits map" should be more actionable #15195

Approach

A 'Check database' action is shown on the error message, which resolves the issue.

The error is no longer sent to ACRA

How Has This Been Tested?

Index: AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt b/AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt
--- a/AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt	(revision e3690dd6216a7cc790fffc54fed2dbefb6a9ae51)
+++ b/AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt	(date 1778448859004)
@@ -71,6 +71,8 @@
 import androidx.swiperefreshlayout.widget.SwipeRefreshLayout
 import androidx.work.WorkInfo
 import androidx.work.WorkManager
+import anki.backend.BackendError
+import anki.backend.backendError
 import anki.collection.OpChanges
 import anki.sync.SyncStatusResponse
 import com.google.android.material.progressindicator.LinearProgressIndicator
@@ -202,6 +204,7 @@
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
 import net.ankiweb.rsdroid.Translations
+import net.ankiweb.rsdroid.exceptions.BackendInvalidInputException
 import timber.log.Timber
 import java.io.File
 
@@ -429,6 +432,9 @@
     ) {
         Timber.i("DeckPicker:: Selected deck with id %d", deckId)
         launchCatchingTask {
+            throw BackendInvalidInputException(
+                backendError { message = "deck not found in limits map" }
+            )
             handleDeckSelection(deckId, selectionType)
             if (fragmented) {
                 // Calling notifyDataSetChanged() will update the color of the selected deck.

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

Regression cover: backend does not change the text

[david-allison]

This complexity comes from the fact that we cannot call showDatabaseErrorDialog without context being an AnkiActivity derivative

[david-allison]

Unsure if this qualifies for 2.24.1 - reviewer's choice

[mikehardy]

I like it but this feels more like a feature than a bugfix, and it's already in an area where I user might be in trouble so to speak. It's not great to continue leaving them without the ability to fix, now that we know it's possible, but there's always a risk of something unintended - I'd rather this marinate on main for a while

[mikehardy]

reasoning through the !! to verify safety - there wouldn't be a neutralButton at all if the helpAction didn't exist above, ergo for the listener on neutral to be called, the helpAction is non null

[david-allison]

Works for me, it's been a longstanding issue and I was hoping for a fast 2.25