Skip to content

refactor: move some CollectionHelper methods to SetupStorage.kt - #21348

Merged
david-allison merged 1 commit into
ankidroid:mainfrom
david-allison:setup-storage-refactor
Jul 6, 2026
Merged

refactor: move some CollectionHelper methods to SetupStorage.kt#21348
david-allison merged 1 commit into
ankidroid:mainfrom
david-allison:setup-storage-refactor

Conversation

@david-allison

@david-allison david-allison commented Jul 6, 2026

Copy link
Copy Markdown
Member

Note

Assisted-by: Claude Fable 5

Purpose / Description

I split this out of the following PR for a quick review.

Prep for moving CollectionHelper to :anki-common.

Collection creation will become a startup concern, but collection
access will move to :anki-common.

Fixes

Approach

How does this change address the problem?

How Has This Been Tested?

Non-functional

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Prep for moving CollectionHelper to :anki-common.

Collection creation will become a startup concern, but collection
 access will move to :anki-common.

* Part of 19552
* Part of 13574
* Part of 20737

Assisted-by: Claude Fable 5

@criticalAY criticalAY left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetupStorage isn't self-contained yet, fine and expected for an incremental split from #21343 so all cool, thanks

@criticalAY criticalAY added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jul 6, 2026
@david-allison david-allison changed the title refactor: move helpers to SetupStorage.kt refactor: move some CollectionHelper methods to SetupStorage.kt Jul 6, 2026
@david-allison
david-allison added this pull request to the merge queue Jul 6, 2026
Merged via the queue into ankidroid:main with commit bed407f Jul 6, 2026
20 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone Jul 6, 2026
@github-actions github-actions Bot removed the Needs Second Approval Has one approval, one more approval to merge label Jul 6, 2026
@david-allison
david-allison deleted the setup-storage-refactor branch July 7, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants