Skip to content

Enable edge to edge for NoteTypeFieldEditor activity - #21569

Open
lukstbit wants to merge 1 commit into
ankidroid:mainfrom
lukstbit:feat-edge-notytpefieldeditor
Open

Enable edge to edge for NoteTypeFieldEditor activity#21569
lukstbit wants to merge 1 commit into
ankidroid:mainfrom
lukstbit:feat-edge-notytpefieldeditor

Conversation

@lukstbit

Copy link
Copy Markdown
Member

Purpose / Description

Enables edge to edge for NoteTypeFieldEditor activity. Just using fitSystemWindows didn't really work.

Some images:

Initial look:
Screenshot_20260820_200518

API 28:
Screenshot_20260820_195710
Screenshot_20260820_195726
Screenshot_20260820_195739

API 36:

Screenshot_20260820_195607 Screenshot_20260820_195625 Screenshot_20260820_195637

Fixes

How Has This Been Tested?

Manually on two emulators(checked a dark theme as well): API 28(big notch + navigation bar) and API 36 (punch cutout _ navigation bar)

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • AllActivitiesScreenshotTest: 1 change
All 1 changed screenshots

AllActivitiesScreenshotTest

  • NoteTypeFieldEditor_edgeToEdge_compare.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edge to edge: verify NoteTypeFieldEditor

1 participant