Enable edge to edge for NoteTypeFieldEditor activity - #21569
Open
lukstbit wants to merge 1 commit into
Open
Conversation
Contributor
|
Snapshot diff report vs
All 1 changed screenshotsAllActivitiesScreenshotTest
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Enables edge to edge for NoteTypeFieldEditor activity. Just using fitSystemWindows didn't really work.
Some images:
Initial look:

API 28:



API 36:
Fixes
NoteTypeFieldEditor#21509How Has This Been Tested?
Manually on two emulators(checked a dark theme as well): API 28(big notch + navigation bar) and API 36 (punch cutout _ navigation bar)
Checklist