fix: keep terminal handlers synced after reset - #7
Open
hossainemruz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reset()replaces the bufferTesting
bun test lib/terminal.test.ts— 149 passedbun run typecheckbun test— 373 passedbunx biome check lib/selection-manager.ts lib/terminal.test.tsbun run build:lib && bun run build:wasm-copyBefore: Only first few rows are selectable.


After: All rows are selectable.
Existing baseline issues
Repository-wide
bun run fmtandbun run lintstill report pre-existing findings in unrelated viewport/iris reproduction files andlib/terminal.ts:1881-1889; this PR introduces no new findings in its edited regions.Disclosure
The changes of this PR is entirely generated by AI. I only validated the behavior manually.