Skip to content

fix: keep terminal handlers synced after reset - #7

Open
hossainemruz wants to merge 1 commit into
anomalyco:mainfrom
hossainemruz:fix/emruz/mouse-handler-on-reset
Open

fix: keep terminal handlers synced after reset#7
hossainemruz wants to merge 1 commit into
anomalyco:mainfrom
hossainemruz:fix/emruz/mouse-handler-on-reset

Conversation

@hossainemruz

@hossainemruz hossainemruz commented Aug 31, 2026

Copy link
Copy Markdown

Summary

  • resolve selection data from the current WASM terminal after reset() replaces the buffer
  • clear selection state before freeing the old terminal and make mouse-mode checks use the replacement terminal
  • add regressions for selection below the original 24-row boundary and mouse tracking after reset
  • regenerate committed ESM, CJS, and declaration artifacts

Testing

  • bun test lib/terminal.test.ts — 149 passed
  • bun run typecheck
  • bun test — 373 passed
  • bunx biome check lib/selection-manager.ts lib/terminal.test.ts
  • bun run build:lib && bun run build:wasm-copy

Before: Only first few rows are selectable.
image
After: All rows are selectable.
image

Existing baseline issues

Repository-wide bun run fmt and bun run lint still report pre-existing findings in unrelated viewport/iris reproduction files and lib/terminal.ts:1881-1889; this PR introduces no new findings in its edited regions.

Disclosure

The changes of this PR is entirely generated by AI. I only validated the behavior manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant