refactor(desktop): making terminal state and cache to be scoped by the server key and dir#17596
Open
OpeOginni wants to merge 3 commits intoanomalyco:devfrom
Open
refactor(desktop): making terminal state and cache to be scoped by the server key and dir#17596OpeOginni wants to merge 3 commits intoanomalyco:devfrom
OpeOginni wants to merge 3 commits intoanomalyco:devfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17592
Type of change
What does this PR do?
The PR allows the keys used to persist terminal data to be scoped to the serverKey and directory not just the directory, helps in cases where users with multiple servers but the same directly can run into no conflicts.
How did you verify your code works?
Tested on my local desktop environment with the update.
Screenshots / recordings
Checklist