Skip to content

feat(app): add record-keys shortcut search#17606

Open
anduimagui wants to merge 3 commits intoanomalyco:devfrom
anduimagui:feat/app-record-keys-search
Open

feat(app): add record-keys shortcut search#17606
anduimagui wants to merge 3 commits intoanomalyco:devfrom
anduimagui:feat/app-record-keys-search

Conversation

@anduimagui
Copy link
Contributor

@anduimagui anduimagui commented Mar 15, 2026

Issue for this PR

Closes #

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This adds a VS Code-style record-keys mode to the shortcuts settings search.

The search field now has an inline keyboard toggle that switches between normal fuzzy text search and exact shortcut capture. While record mode is active, the input shows a more obvious active state, displays a red REC badge, captures the pressed shortcut, and filters the shortcuts list by exact keybind match. The same mode can also be toggled with Cmd+Alt+K on macOS and Ctrl+Alt+K elsewhere, using the physical K key so Alt/Option keyboard layouts do not break it.

This works by reusing the existing keybind parsing and signature matching primitives instead of introducing a separate search path. It also keeps the capture flow isolated from row-level shortcut rebinding so searching by shortcut and editing a matching shortcut do not reset the filtered view.

How did you verify your code works?

I tested the change locally in the app settings shortcuts panel by toggling record mode from the inline keyboard icon and with Cmd+Alt+K, confirming that exact shortcut capture filters the list, preserves the filtered view while rebinding a matching row, and exits cleanly.

I also ran bun turbo typecheck, which passed during push.

Screenshots / recordings

Opencode-desktop.mp4

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions bot added the needs:compliance This means the issue will auto-close after 2 hours. label Mar 15, 2026
@github-actions github-actions bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Mar 15, 2026
@github-actions
Copy link
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@anduimagui anduimagui marked this pull request as ready for review March 15, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant