feat(app): add record-keys shortcut search#17606
Open
anduimagui wants to merge 3 commits intoanomalyco:devfrom
Open
feat(app): add record-keys shortcut search#17606anduimagui wants to merge 3 commits intoanomalyco:devfrom
anduimagui wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
This adds a VS Code-style record-keys mode to the shortcuts settings search.
The search field now has an inline keyboard toggle that switches between normal fuzzy text search and exact shortcut capture. While record mode is active, the input shows a more obvious active state, displays a red
RECbadge, captures the pressed shortcut, and filters the shortcuts list by exact keybind match. The same mode can also be toggled withCmd+Alt+Kon macOS andCtrl+Alt+Kelsewhere, using the physicalKkey so Alt/Option keyboard layouts do not break it.This works by reusing the existing keybind parsing and signature matching primitives instead of introducing a separate search path. It also keeps the capture flow isolated from row-level shortcut rebinding so searching by shortcut and editing a matching shortcut do not reset the filtered view.
How did you verify your code works?
I tested the change locally in the app settings shortcuts panel by toggling record mode from the inline keyboard icon and with
Cmd+Alt+K, confirming that exact shortcut capture filters the list, preserves the filtered view while rebinding a matching row, and exits cleanly.I also ran
bun turbo typecheck, which passed during push.Screenshots / recordings
Opencode-desktop.mp4
Checklist