fix(app): ignore stale file tree requests after reset - #47757
Open
Woolgathererer wants to merge 1 commit into
Open
fix(app): ignore stale file tree requests after reset#47757Woolgathererer wants to merge 1 commit into
Woolgathererer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #47741
Type of change
What does this PR do?
After a file-tree reset, an old listing could delete a newer pending request, overwrite its file list, or report a stale error. Check that each promise still owns its in-flight entry before applying results, errors, or cleanup.
The production change is three guards in
tree-store.ts; there are no API or layout changes.How did you verify your code works?
bun test --conditions=solid src/context/file/tree-store.test.ts src/context/file-content-eviction-accounting.test.ts src/components/file-tree.test.ts src/components/file-tree-v2-model.test.ts, frompackages/app).bun typecheckinpackages/app, Prettier, andgit diff --checkpass.Screenshots / recordings
No layout change. Verified the request race at the store boundary; no desktop UI recording was captured.
Checklist