Skip to content

Fix [timeout] restart for credential-less dev processes #6961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jl4nz wants to merge 1 commit into
base: dev
Choose a base branch
from
+9 −2
Open

Fix [timeout] restart for credential-less dev processes #6961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions cmd/sst/mosaic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func CmdMosaic(c *cli.Cli) error {
var cmd *exec.Cmd
var last *dev.EnvResponse
processExited := make(chan bool)
timeout := time.Minute * 50
timeout := time.Hour * 24
timer := time.NewTimer(timeout)
defer timer.Stop()

Expand Down Expand Up @@ -102,8 +102,15 @@ func CmdMosaic(c *cli.Cli) error {
if err != nil {
return err
}
if _, ok := nextEnv.Env["AWS_ACCESS_KEY_ID"]; ok {
if _, ok := nextEnv.Env["AWS_ACCESS_KEY_ID"]; ok && timeout != time.Minute*45 {
timeout = time.Minute * 45
if !timer.Stop() {
select {
case <-timer.C:
default:
}
}
timer.Reset(timeout)
}
if last == nil || diff(last.Env, nextEnv.Env) || last.Command != nextEnv.Command {
if cmd != nil && cmd.Process != nil {
Expand Down
Loading