Add the mcp connection plugin #9

alinabuzachis · 2025-10-31T08:30:24Z

SUMMARY

Add the mcp connection plugin

Depends On #7

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

mcp

softwarefactory-project-zuul · 2025-10-31T08:40:34Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ea7c5ab8d707487dbdf459d6b1fb7d66

✔️ build-ansible-collection SUCCESS in 5m 54s
✔️ integration-ansible-mcp SUCCESS in 2m 03s

softwarefactory-project-zuul · 2025-10-31T08:44:05Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/dc73445d99c84bd2984b144e7012a1c5

✔️ build-ansible-collection SUCCESS in 5m 51s
✔️ integration-ansible-mcp SUCCESS in 2m 01s

softwarefactory-project-zuul · 2025-10-31T10:03:58Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/06223673584b43babd50ff9b055d9ab5

✔️ build-ansible-collection SUCCESS in 6m 58s
✔️ integration-ansible-mcp SUCCESS in 2m 00s

softwarefactory-project-zuul · 2025-10-31T10:22:30Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6885aca350bd4e58885e0da8afa3d772

✔️ build-ansible-collection SUCCESS in 5m 43s
✔️ integration-ansible-mcp SUCCESS in 1m 58s

softwarefactory-project-zuul · 2025-10-31T13:34:55Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d265100f8efa4a14b419f35916625b30

✔️ build-ansible-collection SUCCESS in 5m 43s
✔️ integration-ansible-mcp SUCCESS in 2m 08s

softwarefactory-project-zuul · 2025-11-03T14:29:48Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6fab4ec28631482d9dbe437d85890233

✔️ build-ansible-collection SUCCESS in 5m 51s
✔️ integration-ansible-mcp SUCCESS in 1m 55s

abikouo

It will be worth adding unit tests for the single method _load_server_from_manifest() and _create_transport()

abikouo · 2025-11-03T17:12:52Z

tox.ini

    mkdir
    ln
    rm
+    ansible-galaxy


This should be added as depency

If I do not include ansible_galaxy here, it will complain:

linters: failed with ansible-galaxy is not allowed, use allowlist_externals to allow it linters: FAIL code 1 (6.99 seconds)

tests/unit/plugins/connection/test_connection_mcp.py

abikouo · 2025-11-03T17:36:16Z

plugins/connection/mcp.py

+    def close(self) -> None:
+        """Terminate the persistent connection and reset state."""
+        display.vvv("[mcp] Closing MCP connection")
+
+        self._close_client()
+        super().close()  # sets _conn_closed, _connected
+
+    def _close_client(self) -> None:
+        """Close the MCPClient if it exists and reset the reference."""
+        if not self._client:
+            display.vvv("[mcp] No MCP client to close")
+            return
+


why not merging the 2 methods into a single one?

_close_client() exclusively handle the dependency-specific shutdown and error handling for the MCPClient, while close() is a high-level method responsible for coordinating the overall cleanup and calling super().close() for base class state management.

gravesm · 2025-11-03T19:08:33Z

plugins/connection/mcp.py

+        type: dict
+        vars:
+            - name: ansible_mcp_mcp_server_env
+    mcp_bearer_token:


Can we also read this from an MCP_BEARER_TOKEN env var?

gravesm · 2025-11-03T19:12:25Z

plugins/connection/mcp.py

+
+        return manifest[server_name]
+
+    def _create_transport(self, server_name: str, server_info: dict):


The type hinting should show a return type of Transport.

plugins/connection/mcp.py

softwarefactory-project-zuul · 2025-11-04T15:37:16Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ca517efc66a245708411ff14cb69e2f9

✔️ build-ansible-collection SUCCESS in 5m 55s
✔️ integration-ansible-mcp SUCCESS in 2m 07s

gravesm · 2025-11-04T16:08:20Z

plugins/connection/mcp.py

+    - Both stdio and Streamable HTTP transport methods are supported.
+    - All tasks using this connection plugin are run on the Ansible control node.
+options:
+    mcp_server_name:


Sorry, just now noticing. We should probably remove the mcp_ prefix from these options so we don't end up with ansible_mcp_mcp_ for config vars.

No problem, makes sense, removed!

Signed-off-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2025-11-04T17:02:27Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3f5ae761e21449b6b0148edc34ced1e4

✔️ build-ansible-collection SUCCESS in 5m 48s
✔️ integration-ansible-mcp SUCCESS in 2m 05s

alinabuzachis force-pushed the connection/plugin/mcp branch from 4215cf0 to 42fec2e Compare October 31, 2025 08:35

alinabuzachis force-pushed the connection/plugin/mcp branch 2 times, most recently from 6e38155 to 3cac395 Compare October 31, 2025 09:54

alinabuzachis force-pushed the connection/plugin/mcp branch from ea24dbb to b4cbf12 Compare October 31, 2025 10:14

alinabuzachis force-pushed the connection/plugin/mcp branch from b4cbf12 to af69698 Compare October 31, 2025 13:26

abikouo requested changes Nov 3, 2025

View reviewed changes

gravesm reviewed Nov 3, 2025

View reviewed changes

beeankha reviewed Nov 3, 2025

View reviewed changes

plugins/connection/mcp.py Show resolved Hide resolved

alinabuzachis force-pushed the connection/plugin/mcp branch 7 times, most recently from 73abd34 to e11669a Compare November 4, 2025 15:28

alinabuzachis requested review from abikouo, beeankha and gravesm November 4, 2025 15:31

gravesm reviewed Nov 4, 2025

View reviewed changes

mandar242 added 4 commits November 4, 2025 17:46

add MCPClient class

fa3fcdf

minor fix

64e58f2

modified based on feedback

af8e349

modified based on feedback

247c2b6

mandar242 and others added 12 commits November 4, 2025 17:46

restructure validate, other minox fixes

ef1a366

move tests to unit/plugins/module_utils

44edcb3

linter fix

3626e9b

Add mcp connection plugin

b1bb02c

Signed-off-by: Alina Buzachis <[email protected]>

Update: mcp connection plugin

6b7808b

Signed-off-by: Alina Buzachis <[email protected]>

Update

2f08e80

Signed-off-by: Alina Buzachis <[email protected]>

Fixes

f9bdf0f

Signed-off-by: Alina Buzachis <[email protected]>

Add ansible.utils dependency

b36e2f0

Signed-off-by: Alina Buzachis <[email protected]>

Reaname

80754ce

Signed-off-by: Alina Buzachis <[email protected]>

Minor fix

8b6dd5a

Signed-off-by: Alina Buzachis <[email protected]>

Apply suggestions

66f99f3

Signed-off-by: Alina Buzachis <[email protected]>

Rebase and remove mcp_ prefix from parameters

82a448c

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis force-pushed the connection/plugin/mcp branch from e11669a to 82a448c Compare November 4, 2025 16:53

alinabuzachis requested a review from gravesm November 4, 2025 16:57

gravesm approved these changes Nov 4, 2025

View reviewed changes

abikouo approved these changes Nov 4, 2025

View reviewed changes

beeankha approved these changes Nov 4, 2025

View reviewed changes

alinabuzachis merged commit abad8a5 into ansible-collections:main Nov 4, 2025
40 checks passed


		return manifest[server_name]

		def _create_transport(self, server_name: str, server_info: dict):

Add the mcp connection plugin #9

Add the mcp connection plugin #9

Uh oh!

Conversation

alinabuzachis commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

ISSUE TYPE

COMPONENT NAME

Uh oh!

softwarefactory-project-zuul bot commented Oct 31, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 31, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 31, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 31, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 31, 2025

Uh oh!

softwarefactory-project-zuul bot commented Nov 3, 2025

Uh oh!

abikouo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Nov 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul bot commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alinabuzachis commented Oct 31, 2025 •

edited

Loading