Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection/aws_ssm - create S3clientmanager class and move related methods #2255

Conversation

mandar242
Copy link
Contributor

SUMMARY

create S3clientmanager class and move related methods
Fixes ACA-2097

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

connection/aws_ssm

@mandar242 mandar242 requested a review from abikouo February 27, 2025 01:23

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@mandar242 mandar242 force-pushed the s3clientmanager_class branch from 657ca6a to 47bd8be Compare February 27, 2025 07:10
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/240b73518fb54b7d9ce5f9f2d638df10

✔️ ansible-galaxy-importer SUCCESS in 3m 43s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 50s
✔️ ansible-test-splitter SUCCESS in 4m 02s
✔️ integration-community.aws-1 SUCCESS in 24m 43s
✔️ integration-community.aws-2 SUCCESS in 18m 46s
✔️ integration-community.aws-3 SUCCESS in 17m 48s
✔️ integration-community.aws-4 SUCCESS in 14m 58s
✔️ integration-community.aws-5 SUCCESS in 16m 02s
✔️ integration-community.aws-6 SUCCESS in 13m 05s
✔️ integration-community.aws-7 SUCCESS in 14m 36s
✔️ integration-community.aws-8 SUCCESS in 14m 38s
✔️ integration-community.aws-9 SUCCESS in 14m 52s
✔️ integration-community.aws-10 SUCCESS in 4m 20s
✔️ integration-community.aws-11 SUCCESS in 16m 34s
Skipped 11 jobs

This comment was marked as outdated.

@mandar242 mandar242 requested review from beeankha and tremble March 4, 2025 18:34
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c45ac205d4a8475ab5731317dc724eb5

ansible-galaxy-importer FAILURE in 5m 05s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 20s
✔️ ansible-test-splitter SUCCESS in 3m 58s
✔️ integration-community.aws-1 SUCCESS in 25m 09s
✔️ integration-community.aws-2 SUCCESS in 16m 19s
✔️ integration-community.aws-3 SUCCESS in 16m 54s
✔️ integration-community.aws-4 SUCCESS in 13m 41s
✔️ integration-community.aws-5 SUCCESS in 14m 06s
✔️ integration-community.aws-6 SUCCESS in 15m 12s
✔️ integration-community.aws-7 SUCCESS in 15m 24s
✔️ integration-community.aws-8 SUCCESS in 12m 59s
✔️ integration-community.aws-9 SUCCESS in 14m 54s
✔️ integration-community.aws-10 SUCCESS in 4m 11s
✔️ integration-community.aws-11 SUCCESS in 13m 35s
Skipped 11 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e3cc2e6722f34e2786e511317a3e5824

ansible-galaxy-importer FAILURE in 5m 44s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 19s
✔️ ansible-test-splitter SUCCESS in 4m 02s
✔️ integration-community.aws-1 SUCCESS in 26m 01s
✔️ integration-community.aws-2 SUCCESS in 15m 03s
✔️ integration-community.aws-3 SUCCESS in 14m 18s
✔️ integration-community.aws-4 SUCCESS in 16m 07s
✔️ integration-community.aws-5 SUCCESS in 14m 43s
✔️ integration-community.aws-6 SUCCESS in 13m 03s
✔️ integration-community.aws-7 SUCCESS in 13m 31s
✔️ integration-community.aws-8 SUCCESS in 15m 22s
✔️ integration-community.aws-9 SUCCESS in 17m 21s
✔️ integration-community.aws-10 SUCCESS in 5m 52s
✔️ integration-community.aws-11 SUCCESS in 15m 25s
Skipped 11 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/48c20dbfdd364ecd8a80f75d8d20e37b

ansible-galaxy-importer FAILURE in 6m 39s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 19s
✔️ ansible-test-splitter SUCCESS in 3m 57s
✔️ integration-community.aws-1 SUCCESS in 23m 38s
✔️ integration-community.aws-2 SUCCESS in 13m 21s
✔️ integration-community.aws-3 SUCCESS in 15m 34s
✔️ integration-community.aws-4 SUCCESS in 14m 49s
✔️ integration-community.aws-5 SUCCESS in 14m 17s
✔️ integration-community.aws-6 SUCCESS in 15m 11s
✔️ integration-community.aws-7 SUCCESS in 15m 04s
✔️ integration-community.aws-8 SUCCESS in 14m 57s
✔️ integration-community.aws-9 SUCCESS in 14m 27s
✔️ integration-community.aws-10 SUCCESS in 7m 34s
✔️ integration-community.aws-11 SUCCESS in 14m 52s
Skipped 11 jobs

@@ -0,0 +1,124 @@
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add copyright info at the top of this file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a2d68ccdceec4dcaa52265d667f357e1

ansible-galaxy-importer FAILURE in 5m 07s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 16s
✔️ ansible-test-splitter SUCCESS in 3m 58s
✔️ integration-community.aws-1 SUCCESS in 25m 46s
✔️ integration-community.aws-2 SUCCESS in 15m 47s
✔️ integration-community.aws-3 SUCCESS in 18m 11s
✔️ integration-community.aws-4 SUCCESS in 16m 06s
✔️ integration-community.aws-5 SUCCESS in 25m 41s
✔️ integration-community.aws-6 SUCCESS in 14m 16s
✔️ integration-community.aws-7 SUCCESS in 16m 49s
✔️ integration-community.aws-8 SUCCESS in 13m 47s
✔️ integration-community.aws-9 SUCCESS in 17m 03s
✔️ integration-community.aws-10 SUCCESS in 5m 15s
✔️ integration-community.aws-11 SUCCESS in 15m 24s
Skipped 11 jobs

@mandar242 mandar242 added the mergeit Merge the PR (SoftwareFactory) label Mar 10, 2025
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/3e0b3e50304e48feabdd559a767b4b6b

ansible-galaxy-importer FAILURE in 4m 37s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 04s
✔️ ansible-test-splitter SUCCESS in 3m 52s
✔️ integration-community.aws-1 SUCCESS in 24m 06s
✔️ integration-community.aws-2 SUCCESS in 15m 57s
✔️ integration-community.aws-3 SUCCESS in 15m 52s
✔️ integration-community.aws-4 SUCCESS in 15m 55s
✔️ integration-community.aws-5 SUCCESS in 16m 06s
✔️ integration-community.aws-6 SUCCESS in 13m 24s
✔️ integration-community.aws-7 SUCCESS in 18m 15s
✔️ integration-community.aws-8 SUCCESS in 17m 24s
✔️ integration-community.aws-9 SUCCESS in 16m 02s
✔️ integration-community.aws-10 SUCCESS in 4m 18s
✔️ integration-community.aws-11 SUCCESS in 17m 04s
Skipped 11 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d9899d0 into ansible-collections:main Mar 10, 2025
86 of 87 checks passed
Copy link

patchback bot commented Mar 10, 2025

Backport to stable-9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply d9899d0 on top of patchback/backports/stable-9/d9899d02302e965590d93ec64e4441cdc814ac6a/pr-2255

Backporting merged PR #2255 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.aws.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-9/d9899d02302e965590d93ec64e4441cdc814ac6a/pr-2255 upstream/stable-9
  4. Now, cherry-pick PR connection/aws_ssm - create S3clientmanager class and move related methods #2255 contents into that branch:
    $ git cherry-pick -x d9899d02302e965590d93ec64e4441cdc814ac6a
    If it'll yell at you with something like fatal: Commit d9899d02302e965590d93ec64e4441cdc814ac6a is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x d9899d02302e965590d93ec64e4441cdc814ac6a
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR connection/aws_ssm - create S3clientmanager class and move related methods #2255 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-9/d9899d02302e965590d93ec64e4441cdc814ac6a/pr-2255
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

mandar242 added a commit to mandar242/community.aws that referenced this pull request Mar 10, 2025
…thods (ansible-collections#2255)

SUMMARY

create S3clientmanager class and move related methods
Fixes ACA-2097

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

connection/aws_ssm

Reviewed-by: Bikouo Aubin
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Mark Chappell
Reviewed-by: Bianca Henderson <beeankha@gmail.com>
(cherry picked from commit d9899d0)
mandar242 added a commit to mandar242/community.aws that referenced this pull request Mar 19, 2025
…thods (ansible-collections#2255)

SUMMARY

create S3clientmanager class and move related methods
Fixes ACA-2097

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

connection/aws_ssm

Reviewed-by: Bikouo Aubin
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Mark Chappell
Reviewed-by: Bianca Henderson <beeankha@gmail.com>
(cherry picked from commit d9899d0)
Copy link

patchback bot commented Mar 19, 2025

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/d9899d02302e965590d93ec64e4441cdc814ac6a/pr-2255

Backported as #2268

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 19, 2025
…thods (#2255)

SUMMARY

create S3clientmanager class and move related methods
Fixes ACA-2097

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

connection/aws_ssm

Reviewed-by: Bikouo Aubin
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Mark Chappell
Reviewed-by: Bianca Henderson <beeankha@gmail.com>
(cherry picked from commit d9899d0)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 20, 2025
…thods (#2255) (#2268)

This is a backport of PR #2255 as merged into main (d9899d0).
SUMMARY

create S3clientmanager class and move related methods
Fixes ACA-2097

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

connection/aws_ssm

Reviewed-by: Bikouo Aubin
Reviewed-by: Bianca Henderson <beeankha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport_failed backport-9 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants