-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connection/aws_ssm - create S3clientmanager class and move related methods #2255
connection/aws_ssm - create S3clientmanager class and move related methods #2255
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
657ca6a
to
47bd8be
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 43s (non-voting) |
This comment was marked as outdated.
This comment was marked as outdated.
…ty to S3ClientManager class
…e client for s3 & ssm initialization
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 05s (non-voting) |
…tionality is moved to s3clientmanager.initialize_client
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 44s (non-voting) |
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 6m 39s (non-voting) |
@@ -0,0 +1,124 @@ | |||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add copyright info at the top of this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 07s (non-voting) |
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 4m 37s (non-voting) |
d9899d0
into
ansible-collections:main
Backport to stable-9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply d9899d0 on top of patchback/backports/stable-9/d9899d02302e965590d93ec64e4441cdc814ac6a/pr-2255 Backporting merged PR #2255 into main
🤖 @patchback |
…thods (ansible-collections#2255) SUMMARY create S3clientmanager class and move related methods Fixes ACA-2097 ISSUE TYPE Feature Pull Request COMPONENT NAME connection/aws_ssm Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Mark Chappell Reviewed-by: Bianca Henderson <beeankha@gmail.com> (cherry picked from commit d9899d0)
…thods (ansible-collections#2255) SUMMARY create S3clientmanager class and move related methods Fixes ACA-2097 ISSUE TYPE Feature Pull Request COMPONENT NAME connection/aws_ssm Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Mark Chappell Reviewed-by: Bianca Henderson <beeankha@gmail.com> (cherry picked from commit d9899d0)
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #2268 🤖 @patchback |
…thods (#2255) SUMMARY create S3clientmanager class and move related methods Fixes ACA-2097 ISSUE TYPE Feature Pull Request COMPONENT NAME connection/aws_ssm Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Mark Chappell Reviewed-by: Bianca Henderson <beeankha@gmail.com> (cherry picked from commit d9899d0)
…thods (#2255) (#2268) This is a backport of PR #2255 as merged into main (d9899d0). SUMMARY create S3clientmanager class and move related methods Fixes ACA-2097 ISSUE TYPE Feature Pull Request COMPONENT NAME connection/aws_ssm Reviewed-by: Bikouo Aubin Reviewed-by: Bianca Henderson <beeankha@gmail.com>
SUMMARY
create S3clientmanager class and move related methods
Fixes ACA-2097
ISSUE TYPE
COMPONENT NAME
connection/aws_ssm