Refactor connection/aws_ssm plugin by abikouo · Pull Request #2272 · ansible-collections/community.aws

abikouo · 2025-03-26T18:01:45Z

SUMMARY

Add new classes to manage AWS ssm session and subprocess session
Refer to: https://issues.redhat.com/browse/ACA-2100

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

connection/aws_ssm

softwarefactory-project-zuul · 2025-03-26T19:12:40Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/31ac8ef38b9c4988be61038858ce0f2e

✔️ ansible-galaxy-importer SUCCESS in 3m 23s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 20s
✔️ ansible-test-splitter SUCCESS in 4m 27s
❌ integration-community.aws-1 FAILURE in 58m 05s
❌ integration-community.aws-2 FAILURE in 23m 58s
❌ integration-community.aws-3 FAILURE in 24m 11s
❌ integration-community.aws-4 FAILURE in 25m 14s
❌ integration-community.aws-5 FAILURE in 24m 57s
❌ integration-community.aws-6 FAILURE in 24m 02s
❌ integration-community.aws-7 FAILURE in 24m 23s
❌ integration-community.aws-8 FAILURE in 25m 17s
❌ integration-community.aws-9 FAILURE in 24m 44s
✔️ integration-community.aws-10 SUCCESS in 4m 45s
❌ integration-community.aws-11 FAILURE in 25m 01s
Skipped 11 jobs

softwarefactory-project-zuul · 2025-03-27T18:17:02Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/199e3d2a8d674fdfbb1b3a6f582ed9b9

✔️ ansible-galaxy-importer SUCCESS in 3m 15s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 26s
✔️ ansible-test-splitter SUCCESS in 3m 55s
❌ integration-community.aws-1 TIMED_OUT in 1h 00m 25s
❌ integration-community.aws-2 FAILURE in 45m 10s
❌ integration-community.aws-3 FAILURE in 57m 11s
❌ integration-community.aws-4 FAILURE in 36m 26s
❌ integration-community.aws-5 FAILURE in 37m 23s
❌ integration-community.aws-6 FAILURE in 31m 40s
❌ integration-community.aws-7 FAILURE in 50m 05s
❌ integration-community.aws-8 FAILURE in 35m 18s
❌ integration-community.aws-9 FAILURE in 1h 00m 27s
✔️ integration-community.aws-10 SUCCESS in 4m 56s
❌ integration-community.aws-11 FAILURE in 41m 22s
Skipped 11 jobs

softwarefactory-project-zuul · 2025-03-28T15:32:57Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/572de36395cf43908f90f261928c5e19

❌ ansible-galaxy-importer FAILURE in 4m 35s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 42s
✔️ ansible-test-splitter SUCCESS in 4m 05s
✔️ integration-community.aws-1 SUCCESS in 21m 48s
✔️ integration-community.aws-2 SUCCESS in 14m 29s
✔️ integration-community.aws-3 SUCCESS in 15m 01s
✔️ integration-community.aws-4 SUCCESS in 16m 38s
✔️ integration-community.aws-5 SUCCESS in 14m 20s
✔️ integration-community.aws-6 SUCCESS in 17m 37s
✔️ integration-community.aws-7 SUCCESS in 16m 48s
✔️ integration-community.aws-8 SUCCESS in 13m 33s
✔️ integration-community.aws-9 SUCCESS in 13m 11s
✔️ integration-community.aws-10 SUCCESS in 7m 56s
✔️ integration-community.aws-11 SUCCESS in 14m 52s
Skipped 11 jobs

softwarefactory-project-zuul · 2025-04-08T13:11:19Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3cf0f76eff254bea9cbfad613af1a505

✔️ ansible-galaxy-importer SUCCESS in 3m 20s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 21s
✔️ ansible-test-splitter SUCCESS in 4m 05s
✔️ integration-community.aws-1 SUCCESS in 23m 33s
✔️ integration-community.aws-2 SUCCESS in 14m 00s
✔️ integration-community.aws-3 SUCCESS in 13m 54s
✔️ integration-community.aws-4 SUCCESS in 13m 26s
✔️ integration-community.aws-5 SUCCESS in 13m 33s
✔️ integration-community.aws-6 SUCCESS in 13m 38s
✔️ integration-community.aws-7 SUCCESS in 13m 14s
✔️ integration-community.aws-8 SUCCESS in 15m 25s
✔️ integration-community.aws-9 SUCCESS in 13m 46s
✔️ integration-community.aws-10 SUCCESS in 5m 22s
✔️ integration-community.aws-11 SUCCESS in 13m 33s
Skipped 11 jobs

softwarefactory-project-zuul · 2025-04-11T07:55:43Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b62dd9b0bd6e4191b827a1d34cfc42f1

❌ ansible-galaxy-importer FAILURE in 3m 44s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 50s
✔️ ansible-test-splitter SUCCESS in 4m 00s
✔️ integration-community.aws-1 SUCCESS in 22m 06s
✔️ integration-community.aws-2 SUCCESS in 14m 03s
✔️ integration-community.aws-3 SUCCESS in 14m 00s
✔️ integration-community.aws-4 SUCCESS in 15m 29s
✔️ integration-community.aws-5 SUCCESS in 14m 07s
✔️ integration-community.aws-6 SUCCESS in 14m 58s
✔️ integration-community.aws-7 SUCCESS in 14m 48s
✔️ integration-community.aws-8 SUCCESS in 12m 46s
✔️ integration-community.aws-9 SUCCESS in 12m 01s
✔️ integration-community.aws-10 SUCCESS in 9m 02s
✔️ integration-community.aws-11 SUCCESS in 13m 19s
Skipped 11 jobs

softwarefactory-project-zuul · 2025-04-11T14:01:33Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d0d2f578cb3c4070bcfea404bd159073

❌ ansible-galaxy-importer FAILURE in 3m 46s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 57s
✔️ ansible-test-splitter SUCCESS in 4m 20s
✔️ integration-community.aws-1 SUCCESS in 21m 57s
✔️ integration-community.aws-2 SUCCESS in 14m 47s
✔️ integration-community.aws-3 SUCCESS in 14m 25s
✔️ integration-community.aws-4 SUCCESS in 13m 50s
✔️ integration-community.aws-5 SUCCESS in 13m 35s
✔️ integration-community.aws-6 SUCCESS in 13m 13s
✔️ integration-community.aws-7 SUCCESS in 13m 24s
✔️ integration-community.aws-8 SUCCESS in 13m 58s
✔️ integration-community.aws-9 SUCCESS in 16m 39s
✔️ integration-community.aws-10 SUCCESS in 4m 19s
✔️ integration-community.aws-11 SUCCESS in 13m 55s
Skipped 11 jobs

patchback · 2025-04-11T14:01:40Z

Backport to stable-9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply d6fefc6 on top of patchback/backports/stable-9/d6fefc6646abef9585e88c00d721950fbd6200f7/pr-2272

Backporting merged PR #2272 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/community.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-9/d6fefc6646abef9585e88c00d721950fbd6200f7/pr-2272 upstream/stable-9

Now, cherry-pick PR Refactor connection/aws_ssm plugin #2272 contents into that branch:
```
$ git cherry-pick -x d6fefc6646abef9585e88c00d721950fbd6200f7
```
If it'll yell at you with something like fatal: Commit d6fefc6646abef9585e88c00d721950fbd6200f7 is a merge but no -m option was given., add -m 1 as follows instead:
```
$ git cherry-pick -m1 -x d6fefc6646abef9585e88c00d721950fbd6200f7
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Refactor connection/aws_ssm plugin #2272 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-9/d6fefc6646abef9585e88c00d721950fbd6200f7/pr-2272

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2025-04-11T15:20:32Z

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/d6fefc6646abef9585e88c00d721950fbd6200f7/pr-2272

Backported as #2282

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

SUMMARY Add new classes to manage AWS ssm session and subprocess session Refer to: https://issues.redhat.com/browse/ACA-2100 ISSUE TYPE Feature Pull Request COMPONENT NAME connection/aws_ssm Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Bikouo Aubin Reviewed-by: Bianca Henderson <beeankha@gmail.com> (cherry picked from commit d6fefc6)

This is a backport of PR #2272 as merged into main (d6fefc6). SUMMARY Add new classes to manage AWS ssm session and subprocess session Refer to: https://issues.redhat.com/browse/ACA-2100 ISSUE TYPE Feature Pull Request COMPONENT NAME connection/aws_ssm Reviewed-by: Alina Buzachis

SUMMARY Add new classes to manage AWS ssm session and subprocess session Refer to: https://issues.redhat.com/browse/ACA-2100 ISSUE TYPE Feature Pull Request COMPONENT NAME connection/aws_ssm Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Bikouo Aubin Reviewed-by: Bianca Henderson <beeankha@gmail.com> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@d6fefc6

SUMMARY Add new classes to manage AWS ssm session and subprocess session Refer to: https://issues.redhat.com/browse/ACA-2100 ISSUE TYPE Feature Pull Request COMPONENT NAME connection/aws_ssm Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Bikouo Aubin Reviewed-by: Bianca Henderson <beeankha@gmail.com>

abikouo force-pushed the refactor_aws_ssm_session_manager branch from de4ecc9 to e9fc68b Compare March 28, 2025 14:57

abikouo changed the title ~~DNM - Refactor connection/aws_ssm plugin~~ Refactor connection/aws_ssm plugin Mar 31, 2025

abikouo mentioned this pull request Mar 31, 2025

connection/aws_ssm - create TerminalManager class and move related methods #2270

Merged

abikouo force-pushed the refactor_aws_ssm_session_manager branch from e9fc68b to e85ab0a Compare April 8, 2025 12:36

alinabuzachis approved these changes Apr 9, 2025

View reviewed changes

gravesm reviewed Apr 9, 2025

View reviewed changes

Comment thread plugins/connection/aws_ssm.py

abikouo requested a review from gravesm April 9, 2025 15:05

beeankha approved these changes Apr 10, 2025

View reviewed changes

Refactor connection/aws_ssm plugin

57b0da8

abikouo force-pushed the refactor_aws_ssm_session_manager branch from e85ab0a to 57b0da8 Compare April 11, 2025 07:17

gravesm approved these changes Apr 11, 2025

View reviewed changes

alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Apr 11, 2025

github-actions Bot added the backport-9 PR should be backported to the stable-9 branch label Apr 11, 2025

softwarefactory-project-zuul Bot merged commit d6fefc6 into ansible-collections:main Apr 11, 2025
86 of 87 checks passed

github-actions Bot added the backport_failed label Apr 11, 2025

abikouo added backport-9 PR should be backported to the stable-9 branch and removed backport-9 PR should be backported to the stable-9 branch backport_failed labels Apr 11, 2025

patchback Bot mentioned this pull request Apr 11, 2025

[PR #2272/d6fefc66 backport][stable-9] Refactor connection/aws_ssm plugin #2282

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor connection/aws_ssm plugin#2272

Refactor connection/aws_ssm plugin#2272
softwarefactory-project-zuul[bot] merged 1 commit intoansible-collections:mainfrom
abikouo:refactor_aws_ssm_session_manager

abikouo commented Mar 26, 2025 •

edited

Loading

Uh oh!

softwarefactory-project-zuul Bot commented Mar 26, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Mar 27, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Mar 28, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Apr 8, 2025

Uh oh!

Uh oh!

softwarefactory-project-zuul Bot commented Apr 11, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Apr 11, 2025

Uh oh!

Uh oh!

patchback Bot commented Apr 11, 2025 •

edited

Loading

Uh oh!

patchback Bot commented Apr 11, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

abikouo commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

ISSUE TYPE

COMPONENT NAME

Uh oh!

softwarefactory-project-zuul Bot commented Mar 26, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Mar 27, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Mar 28, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Apr 8, 2025

Uh oh!

Uh oh!

softwarefactory-project-zuul Bot commented Apr 11, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Apr 11, 2025

Uh oh!

Uh oh!

patchback Bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to stable-9: 💔 cherry-picking failed — conflicts found

Backporting merged PR #2272 into main

Uh oh!

patchback Bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to stable-9: 💚 backport PR created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

abikouo commented Mar 26, 2025 •

edited

Loading

patchback Bot commented Apr 11, 2025 •

edited

Loading

patchback Bot commented Apr 11, 2025 •

edited

Loading