Fix: Implement LDAP specific authenticator_map group check #648
+174
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This alleiviates case-sensitivity problems when processing groups Other changes: re-factor: move logic for evaluating group claims into the authenticator plugin Current logic moved to the BaseAuthenticatorPlugin, but this allows other plugins to override these check with their own logic for evaluating these strings. Preliminary change for introducing a comparison class to the LDAPAuthenticatorPlugin. AAP-33304
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alleiviates case-sensitivity problems when processing groups
Other change:
re-factor: move logic for evaluating group claims into the authenticator plugin
Current logic moved to the BaseAuthenticatorPlugin, but this allows other
plugins to override these check with their own logic for evaluating these
strings.
Preliminary change for introducing a comparison class to the
LDAPAuthenticatorPlugin.
AAP-33304