validation package rewrite #21
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the rewrite of the validation package I mentioned in #13.
I opened a new PR so you can view the approach. If you think its correct we can continue with it in this style. If not I am happy to just contribute the env parser and we can forget about this approach to validation.
However I do think it has quite a lot of advantages
Here is an example schema
I won't say the approach is perfect, it does have some trade-offs:
For more examples of validation I suggest you look at the tests. I have also implemented a requestParams validator for example.
WARNING: code won't compile because I have not changed every instance of the use of the previous methods. If you decide to move forward with this implementation I'll make a quick update to the PR